Repository navigation
fix: resync planned task timeSpent on manual task-time edit - #279
Merged
Merged
Conversation
adjustTaskTime updated the day task's own duration but never called accumulatePlannedTaskTime, so manually editing the end time of a task pulled in from the task board left the planned task's timeSpent stale. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
github-actions
Bot
added
documentation
Deploying timetrackerpro with
|
| Latest commit: |
ee59202
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1393a194.timetrackerpro.pages.dev |
| Branch Preview URL: | https://fix-planned-task-timespent-r.timetrackerpro.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adjustTaskTimeupdated a day task's owndurationbut never calledaccumulatePlannedTaskTime, so manually editing the end time of a task pulled in from the task board left the linked planned task'stimeSpent(and matchingtimeEntriesduration) stale.accumulatePlannedTaskTimefromadjustTaskTimewhenever an end time is set.Test plan
src/contexts/TimeTracking.test.tsx— "resyncs timeSpent after editing the ended task's time" (watched RED before the fix, GREEN after)pnpm vitest run— 411 tests passpnpm eslinton changed files — cleanpnpm build— clean🤖 Generated with Claude Code