Hi there,
I believe there is an issue in the computation of the jacobian. The line I have referenced is the the partial derivative wrt $\xi_B$. I believe this should be aval.append(deltaT*Kox_ads - deltaT*K_A_ads*saturation_number*conc[2]) not aval.append(deltaT*Kox_ads - deltaT*K_A_ads*saturation_number*conc[0]) as in the code right now.
Since this term in the Jacobian is $C_{A, X=0}$ which is at index 2 not $\xi_A$ which is at index 0.
https://github.com/BattModels/DiffEC/blob/7a00728e27e851eb34c28ed2390d07a193799efb/DiffEC Adsorption/coeff.py#L277C38-L277C44
Hi there,
I believe there is an issue in the computation of the jacobian. The line I have referenced is the the partial derivative wrt$\xi_B$ . I believe this should be
aval.append(deltaT*Kox_ads - deltaT*K_A_ads*saturation_number*conc[2])notaval.append(deltaT*Kox_ads - deltaT*K_A_ads*saturation_number*conc[0])as in the code right now.Since this term in the Jacobian is$C_{A, X=0}$ which is at index 2 not $\xi_A$ which is at index 0.
https://github.com/BattModels/DiffEC/blob/7a00728e27e851eb34c28ed2390d07a193799efb/DiffEC Adsorption/coeff.py#L277C38-L277C44