From fe4679adb421417ad6bd0059610892484a1b00d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ce=CC=81dric=20Andrietti?= Date: Thu, 8 Oct 2026 12:17:43 +0200 Subject: [PATCH 1/2] fix(number-format): allow letter-spacing with fr-FR Intl output Replace U+202F thousands separators with U+2009 after Intl formatting so CSS letter-spacing applies with some font/engine pairs. Share formatNumber between the frontend script and the block editor via src/utils. --- src/edit.js | 35 +++--------------------- src/number-formatter.js | 28 ++------------------ src/utils/format-number.js | 54 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 59 insertions(+), 58 deletions(-) create mode 100644 src/utils/format-number.js diff --git a/src/edit.js b/src/edit.js index d861969..5b63a47 100644 --- a/src/edit.js +++ b/src/edit.js @@ -18,38 +18,9 @@ import { import classnames from 'classnames'; -import './editor.scss'; - -// Custom hook for number formatting -function useNumberFormatter(number, decimalSeparator, minimumFractionDigits) { - const formatNumber = (numberToFormat) => { - if (!numberToFormat && numberToFormat !== 0) { - return numberToFormat; - } - - if (decimalSeparator === 'none') { - return numberToFormat.toString(); - } else if (decimalSeparator === '.' || decimalSeparator === ',') { - return (numberToFormat || 0) - .toString() - .replace('.', decimalSeparator); - } - - const options = { - minimumFractionDigits: minimumFractionDigits || 0, - }; +import { formatNumber } from './utils/format-number'; - try { - return new Intl.NumberFormat(decimalSeparator, options).format( - numberToFormat - ); - } catch (error) { - return numberToFormat.toString(); - } - }; - - return formatNumber(number); -} +import './editor.scss'; export default function Edit({ attributes, setAttributes }) { const { @@ -63,7 +34,7 @@ export default function Edit({ attributes, setAttributes }) { } = attributes; const numberRef = useRef(); - const formattedNumber = useNumberFormatter( + const formattedNumber = formatNumber( number, decimalSeparator, minimumFractionDigits diff --git a/src/number-formatter.js b/src/number-formatter.js index 112f67a..9cb3185 100644 --- a/src/number-formatter.js +++ b/src/number-formatter.js @@ -1,32 +1,8 @@ /** - * Number formatting utility for Key Figure blocks - * Frontend-only formatting (editor formatting handled in React components) + * Number formatting utility for Key Figure blocks (frontend). */ -function formatNumber(numberToFormat, decimalSeparator, minimumFractionDigits) { - if (!numberToFormat && numberToFormat !== 0) { - return numberToFormat; - } - - if (decimalSeparator === 'none') { - return numberToFormat.toString(); - } else if (decimalSeparator === '.' || decimalSeparator === ',') { - return (numberToFormat || 0).toString().replace('.', decimalSeparator); - } - - const options = { - minimumFractionDigits: minimumFractionDigits || 0, - }; - - try { - return new Intl.NumberFormat(decimalSeparator, options).format( - numberToFormat - ); - } catch (error) { - // Fallback to simple string conversion if formatting fails - return numberToFormat.toString(); - } -} +import { formatNumber } from './utils/format-number'; function initializeNumberFormatting() { // Only run on frontend (not in editor) diff --git a/src/utils/format-number.js b/src/utils/format-number.js new file mode 100644 index 0000000..aaa7590 --- /dev/null +++ b/src/utils/format-number.js @@ -0,0 +1,54 @@ +/** + * Intl.NumberFormat (e.g. fr-FR) may insert U+202F (narrow no-break space) as the + * thousands separator. Some fonts in Chromium ignore letter-spacing on text that + * contains U+202F. Thin space (U+2009) keeps grouped digits readable and allows + * CSS tracking (letter-spacing). + */ +const INTNL_NARROW_NO_BREAK_SPACE = /\u202f/g; +const THIN_SPACE = '\u2009'; + +/** + * @param {string} formatted Formatted number string from Intl. + * @return {string} Formatted number with thousands separators safe for CSS tracking. + */ +function normalizeIntlFormattedNumber(formatted) { + return formatted.replace(INTNL_NARROW_NO_BREAK_SPACE, THIN_SPACE); +} + +/** + * @param {number} numberToFormat Value to format. + * @param {string} decimalSeparator Locale id, "none", or literal "." / "," separator. + * @param {number|string} minimumFractionDigits Minimum fraction digits for Intl locales. + * @return {string|number|undefined} Formatted value, or the input when formatting is skipped. + */ +export function formatNumber( + numberToFormat, + decimalSeparator, + minimumFractionDigits +) { + if (!numberToFormat && numberToFormat !== 0) { + return numberToFormat; + } + + if (decimalSeparator === 'none') { + return numberToFormat.toString(); + } + + if (decimalSeparator === '.' || decimalSeparator === ',') { + return (numberToFormat || 0).toString().replace('.', decimalSeparator); + } + + const options = { + minimumFractionDigits: minimumFractionDigits || 0, + }; + + try { + return normalizeIntlFormattedNumber( + new Intl.NumberFormat(decimalSeparator, options).format( + numberToFormat + ) + ); + } catch (error) { + return numberToFormat.toString(); + } +} From 7fa07fc71052fc651636d9797e9922738ce14683 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ce=CC=81dric=20Andrietti?= Date: Thu, 8 Oct 2026 13:38:57 +0200 Subject: [PATCH 2/2] Bump plugin version to 1.1.3 for release --- .plugin-data | 2 +- blockparty-key-figure.php | 4 ++-- languages/blockparty-key-figure-fr_FR.po | 2 +- package-lock.json | 4 ++-- package.json | 2 +- readme.txt | 12 ++++++++---- src/block.json | 2 +- 7 files changed, 16 insertions(+), 12 deletions(-) diff --git a/.plugin-data b/.plugin-data index a7d6a2e..0058422 100644 --- a/.plugin-data +++ b/.plugin-data @@ -1,4 +1,4 @@ { - "version": "1.1.2", + "version": "1.1.3", "slug": "blockparty-key-figure" } diff --git a/blockparty-key-figure.php b/blockparty-key-figure.php index df549b6..54e160a 100644 --- a/blockparty-key-figure.php +++ b/blockparty-key-figure.php @@ -4,7 +4,7 @@ * Description: Key Figure block for WordPress. * Requires at least: 6.2 * Requires PHP: 8.1 - * Version: 1.1.2 + * Version: 1.1.3 * Author: Be API Technical team * Author URI: https://beapi.fr * License: GPL-2.0-or-later @@ -17,7 +17,7 @@ use Blockparty\Key_Figure\Cli\MigrateFromKeyFigureBlockCommand; -define( 'BLOCKPARTY_KEY_FIGURE_VERSION', '1.1.2' ); +define( 'BLOCKPARTY_KEY_FIGURE_VERSION', '1.1.3' ); define( 'BLOCKPARTY_KEY_FIGURE_URL', plugin_dir_url( __FILE__ ) ); define( 'BLOCKPARTY_KEY_FIGURE_DIR', plugin_dir_path( __FILE__ ) ); diff --git a/languages/blockparty-key-figure-fr_FR.po b/languages/blockparty-key-figure-fr_FR.po index 092895f..305d827 100644 --- a/languages/blockparty-key-figure-fr_FR.po +++ b/languages/blockparty-key-figure-fr_FR.po @@ -2,7 +2,7 @@ # This file is distributed under the GPL-2.0-or-later. msgid "" msgstr "" -"Project-Id-Version: Be API Key Figure block 1.1.2\n" +"Project-Id-Version: Be API Key Figure block 1.1.3\n" "Report-Msgid-Bugs-To: https://wordpress.org/support/plugin/blockparty-key-" "figure\n" "POT-Creation-Date: 2024-04-02T21:11:52+00:00\n" diff --git a/package-lock.json b/package-lock.json index 0d77419..d0ea3a0 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "blockparty-key-figure", - "version": "1.1.2", + "version": "1.1.3", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "blockparty-key-figure", - "version": "1.1.2", + "version": "1.1.3", "license": "GPL-2.0-or-later", "dependencies": { "@beapi/icons": "^1.2.5", diff --git a/package.json b/package.json index baa5263..6ffc077 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "blockparty-key-figure", - "version": "1.1.2", + "version": "1.1.3", "description": "Key Figure block for WordPress.", "author": "Be API Technical team", "license": "GPL-2.0-or-later", diff --git a/readme.txt b/readme.txt index b6ac647..d3b6175 100644 --- a/readme.txt +++ b/readme.txt @@ -2,7 +2,7 @@ Contributors: beapi, candrietti Tags: block, key, figure, gutenberg Tested up to: 6.5 -Stable tag: 1.1.2 +Stable tag: 1.1.3 License: GPL-2.0-or-later License URI: https://www.gnu.org/licenses/gpl-2.0.html @@ -74,9 +74,13 @@ Run `wp help blockparty key-figure migrate` for the full list of options. = 1.1.0 - 2026-02-16 = * Markup change: __key wrapper was div, now p (a11y/semantic) -= 1.1.2 - 2026-09-22 = -* Add WP-CLI command to migrate legacy beapi/key-figure block content. - = 1.1.1 - 2026-09-04 = * Add block example. * Move suffix attribute after number control for UX improvment + += 1.1.2 - 2026-09-22 = +* Add WP-CLI command to migrate legacy beapi/key-figure block content. + += 1.1.3 - 2026-10-08 = +* Fix fr-FR Intl thousands separator so CSS letter-spacing applies (U+202F replaced with U+2009). +* Share number formatting between frontend script and block editor. diff --git a/src/block.json b/src/block.json index f2a5fba..3679e5e 100644 --- a/src/block.json +++ b/src/block.json @@ -2,7 +2,7 @@ "$schema": "https://schemas.wp.org/trunk/block.json", "apiVersion": 3, "name": "blockparty/key-figure", - "version": "1.1.2", + "version": "1.1.3", "title": "Key Figure", "category": "widgets", "description": "Key Figure block.",