feat(statics): scope wtgxx tokens to BitGo Trust only

[abhijeet848]

Summary

• Restrict wtgxx (eth, arbeth, opeth, sol, sepeth) and inherited OFC variants to BitGo Trust custody features only
• Add SOL_TOKEN_FEATURES_TRUST_ONLY and lock the feature set in statics tests

Ticket: SCAAS-11102

[linear-code]

SCAAS-11102

[Copilot]

Pull request overview

Restricts WTGXX token variants and inherited OFC assets to BitGo Trust custody.

Changes:

• Adds reusable Trust-only account and Solana feature sets.
• Applies them across Ethereum, Arbitrum, Optimism, Sepolia, and Solana variants.
• Adds coverage for direct and inherited OFC assets.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
modules/statics/src/coinFeatures.ts	Defines Trust-only feature sets.
modules/statics/src/account.ts	Exposes the account Trust-only feature set.
modules/statics/src/coins/erc20Coins.ts	Updates Ethereum and Sepolia WTGXX.
modules/statics/src/coins/solTokens.ts	Updates Solana WTGXX.
modules/statics/src/allCoinsAndTokens.ts	Updates Arbitrum and Optimism WTGXX.
modules/statics/test/unit/coins.ts	Verifies Trust-only custody across all variants.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

[manojkumar138]

LG

[manojkumar138]

@claude review

[github-actions]

Claude finished @manojkumar138's task —— View job

---

Code Review for PR #9595

Todo List:

• Read repository guidelines (CLAUDE.md)
• Analyze PR changes and diff
• Review coinFeatures.ts changes
• Review account.ts changes
• Review erc20Coins.ts changes
• Review solTokens.ts changes
• Review allCoinsAndTokens.ts changes
• Review test coverage in coins.ts
• Provide comprehensive review feedback

---

Review Summary ✅

This PR successfully restricts wtgxx tokens and their variants to BitGo Trust custody only. The implementation is clean and follows established patterns in the codebase.

✅ Strengths

1. Comprehensive Coverage: All wtgxx variants are properly updated:

   • wtgxx (Ethereum) - modules/statics/src/coins/erc20Coins.ts:7068
   • sepeth:wtgxx (Sepolia) - modules/statics/src/coins/erc20Coins.ts:15203
   • arbeth:wtgxx (Arbitrum) - modules/statics/src/allCoinsAndTokens.ts:7499
   • opeth:wtgxx (Optimism) - modules/statics/src/allCoinsAndTokens.ts:7893
   • sol:wtgxx (Solana) - modules/statics/src/coins/solTokens.ts:4296

2. Consistent Pattern: The PR follows the established *_TRUST_ONLY feature pattern used elsewhere in the codebase (e.g., BSC_TOKEN_FEATURES_TRUST_ONLY).

3. Proper Filter Logic: The Trust-only filter correctly retains CoinFeature.CUSTODY_BITGO_TRUST while excluding all other custody jurisdiction features:

   // modules/statics/src/coinFeatures.ts:329
   SOL_TOKEN_FEATURES_TRUST_ONLY = SOL_TOKEN_FEATURES.filter(
     (feature) => feature === CoinFeature.CUSTODY_BITGO_TRUST || !BITGO_CUSTODY_JURISDICTIONS.includes(feature)
   );

4. Excellent Test Coverage: The test suite in modules/statics/test/unit/coins.ts validates:

   • All wtgxx variants include CoinFeature.CUSTODY_BITGO_TRUST
   • All non-Trust custody features are excluded
   • Includes inherited OFC variants (e.g., ofcwtgxx, ofcarbeth:wtgxx) which properly inherit the Trust-only restriction

5. No Breaking Changes: Uses existing feature filtering pattern without introducing new complexity.

🔍 Minor Observations

1. OFC Inheritance Works Correctly: I verified that OFC variants like ofcwtgxx, ofcarbeth:wtgxx, etc. exist in the codebase and will automatically inherit the Trust-only features from their underlying assets. The test coverage confirms this works as expected.

2. Clean Feature Set Definition: The new SOL_TOKEN_FEATURES_TRUST_ONLY export follows the established naming convention and is properly integrated.

✅ Security & Compliance

• Access Control: Properly restricts token access to only BitGo Trust jurisdiction
• No Security Vulnerabilities: Changes are configuration-only and don't introduce execution risks
• Audit Trail: Clear commit message and ticket reference (SCAAS-11102)

✅ Code Quality

• TypeScript Compliance: No type issues introduced
• Consistent Formatting: Follows existing code style
• Documentation: Clear variable names and established patterns

---

Verdict: ✅ APPROVED - This is a well-implemented security feature that properly restricts wtgxx tokens to BitGo Trust custody only. The implementation is thorough, follows established patterns, and includes comprehensive test coverage.

---

Job Run: View workflow run