Skip to content

perf(sdk-core): pin high-entropy encryption to v1 - #9685

Merged
pranavjain97 merged 1 commit into
masterfrom
pranavjain/high-entropy-kdf-no-argon2
Sep 9, 2026
Merged

perf(sdk-core): pin high-entropy encryption to v1#9685
pranavjain97 merged 1 commit into
masterfrom
pranavjain/high-entropy-kdf-no-argon2

Conversation

@pranavjain97

Copy link
Copy Markdown
Contributor

Summary

  • Pins ECDH wallet-share secrets and generated passcode encryption codes to v1/SJCL.
  • Preserves caller-selected encryption for human passphrases and keeps affected API options source-compatible.
  • Updates wallet-share and Box D version assertions.

TICKET: WCN-2616

Test plan

  • modules/sdk-core: yarn unit-test --grep "encryptionVersion threading" (9 passing)
  • modules/key-card: yarn unit-test (37 passing)
  • modules/sdk-core: yarn lint
  • modules/key-card: eslint --quiet src test
  • yarn check-commits
  • yarn lint-changed cannot enumerate packages from a worktree nested under the repository; Lerna resolves ../../modules/* outside this worktree.

@linear-code

linear-code Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

WCN-2616

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@danielpeng1 danielpeng1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit needs to be signed

Comment thread modules/sdk-core/src/bitgo/wallet/wallet.ts
Comment thread modules/sdk-core/src/bitgo/wallet/wallet.ts Outdated
Comment thread modules/sdk-core/test/unit/bitgo/wallet/walletsEncryptionVersion.ts
Comment thread modules/sdk-core/test/unit/bitgo/wallet/walletsEncryptionVersion.ts
@pranavjain97
pranavjain97 force-pushed the pranavjain/high-entropy-kdf-no-argon2 branch from a600af5 to 901400b Compare September 9, 2026 17:55
@pranavjain97
pranavjain97 force-pushed the pranavjain/high-entropy-kdf-no-argon2 branch from 901400b to f58f08a Compare September 9, 2026 19:29
danielpeng1
danielpeng1 previously approved these changes Sep 9, 2026
@pranavjain97
pranavjain97 merged commit f7c69cf into master Sep 9, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants