fix(desktop): harden Windows UI and Linux recording and packaging by richiemcilroy · Pull Request #2153 · CapSoftware/Cap

richiemcilroy · 2026-08-27T07:52:59Z

Windows GPUI controls, dragging, previews, and secondary windows were unreliable; Linux capture, playback, CLI handoff, and package updates also needed fixes. This preserves the macOS crash and recording-recovery fixes already merged into main while adding the remaining desktop changes.

Includes native Windows/Linux window behavior, Linux screen/window/camera capture and timing fixes, playback synchronization, safe fragment paths, export estimates, and verified DEB/RPM/AppImage/Arch packaging with format-specific updater targets.

Validation: Rust formatting for both workspaces, scoped Biome, 28 packaging/preparation tests, shell syntax, actionlint, and all three GPUI dependency patches passed locally. Earlier Windows/Linux sandbox evidence is documented in the source tasks; full CI and fresh Greptile review are pending. No release or production deployment is part of this PR.

Greptile Summary

This PR hardens Windows and Linux desktop behavior while extending Linux capture, playback, CLI finalization, and release packaging.

Improves native GPUI windows, previews, controls, and platform integration.
Updates Linux recording, camera composition, timing, playback, and fragment handling.
Adds DEB, RPM, AppImage, and Arch packaging with format-specific update behavior and validation.

Confidence Score: 5/5

The PR appears safe to merge based on the eligible follow-up findings available in this review.

No blocking failure remains in the review’s publishable or outstanding finding set.

Important Files Changed

Filename	Overview
apps/cli/src/record.rs	Races capture completion against stop requests so foreground and detached recordings proceed to finalization when capture ends unexpectedly.
crates/editor/src/audio_output.rs	Adds callback acknowledgment and playhead synchronization to coordinate audio startup, seeks, and playback corrections.
crates/editor/src/playback.rs	Coordinates playback clock adjustments and audio playhead updates across seeks, starvation recovery, and frame skipping.
crates/recording/src/sources/screen_capture/linux.rs	Expands Linux capture and system-audio behavior across X11, Wayland, PipeWire, and PulseAudio environments.
apps/desktop-gpui/src/app_windows.rs	Adjusts platform-specific window visibility, activation, decorations, sizing, and camera positioning.
apps/desktop-gpui/patches/zed-windows.patch	Patches GPUI Windows rendering, movement, workspace placement, DPI handling, and native caption behavior.
apps/desktop-gpui/patches/zed-linux.patch	Patches Wayland fixed-size window constraints and keeps them synchronized with scale, tiling, and decoration changes.
.github/workflows/desktop-release.yml	Builds, validates, and uploads DEB, RPM, AppImage, and Arch artifacts with package-specific updater targets.
scripts/build-linux-packages.mjs	Orchestrates format-specific Linux package generation from the shared desktop release build.
crates/utils/src/linux_package.rs	Detects Linux installation formats and selects updater targets only for supported DEB and AppImage installations.

_{Reviews (6): Last reviewed commit: "test(utils): use native absolute paths i..." | Re-trigger Greptile}

Context used (5)

Knowledge Base — Desktop application and recording experience
Knowledge Base — Desktop recording orchestration
Knowledge Base — GPUI desktop client
Knowledge Base — Recording and media engine
Knowledge Base — Capture and recording pipeline

superagent-security · 2026-08-27T07:53:04Z

Manage your Superagent protection

Superagent has paused scans for this repository because this unlinked GitHub App installation has used all three included PR scans.

You have 0 of 3 included PR scans remaining.

Create a free account to continue protection, manage scan settings, review security history, and control which repositories are protected.

richiemcilroy · 2026-08-27T07:53:21Z