Add animated gradients and improve Windows desktop UI - #2154
Conversation
Manage your Superagent protectionSuperagent has paused scans for this repository because this unlinked GitHub App installation has used all three included PR scans. You have 0 of 3 included PR scans remaining. Create a free account to continue protection, manage scan settings, review security history, and control which repositories are protected. |
|
|
||
| export const commands = { | ||
| async animatedGradientCatalog() : Promise<AnimatedGradientCatalog> { | ||
| return await TAURI_INVOKE("animated_gradient_catalog"); | ||
| }, | ||
| async randomAnimatedGradient() : Promise<AnimatedGradientConfig> { |
There was a problem hiding this comment.
This directly edits a generated tauri.ts binding, so regeneration can overwrite the added commands and types or leave the committed output out of sync with its Rust source. Update the Specta source and commit output produced by the supported generation workflow instead.
Context Used: AGENTS.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src/utils/tauri.ts
Line: 6-11
Comment:
**Generated binding edited**
This directly edits a generated `tauri.ts` binding, so regeneration can overwrite the added commands and types or leave the committed output out of sync with its Rust source. Update the Specta source and commit output produced by the supported generation workflow instead.
**Context Used:** AGENTS.md ([source](https://github.com/capsoftware/cap/blob/main/AGENTS.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
hey @greptileai, please re-review the PR |
Adds Animated Gradient backgrounds to both Studio editors, with 12 presets, editable color stops, motion and appearance controls, randomization, saved gradients, and remembered settings. The shared GPU renderer uses deterministic timeline animation and a bounded intermediate surface.
Improves GPUI on Windows with a native tray, window controls and dragging, app icons, shadow handling, and no console window in packaged builds. Export progress now waits until a destination file has been chosen.
Validation: desktop TypeScript and scoped Biome checks, 42 focused GPUI tests, 6 project tests, 6 persistence tests, and GPUI compilation pass. The new shader passes standalone validation; GPU regression tests and playback/export renderer timings are still running after a local compiler stall. Windows metadata checks passed, but a native Windows build and UI smoke test remain unverified.
The committed
apps/desktop/src/utils/tauri.tswas generated by the existingtypescript_bindings_tests::export_typescript_bindingstest inapps/desktop/src-tauri/src/lib.rs, using the Specta builder with the two new Rust commands and exported library type. Re-running that generator reproduces the published file byte-for-byte; no binding additions were hand-written.Greptile Summary
This PR adds configurable animated-gradient backgrounds across both desktop editors and shared rendering infrastructure, alongside Windows GPUI shell improvements and a revised export-file selection flow.
Confidence Score: 5/5
The PR appears safe to merge because the previously reported generated-binding issue is resolved and no blocking failure remains.
No blocking failure remains.
Important Files Changed
Reviews (2): Last reviewed commit: "fix: keep gradient stop drags in one und..." | Re-trigger Greptile