From 480c679ff9bf89f4da2479a42424781c7d6a9378 Mon Sep 17 00:00:00 2001 From: Hubert Bugaj Date: Tue, 10 Nov 2026 18:53:47 +0100 Subject: [PATCH] ci: drop mpool_select_killer regression step The step guarded against MpoolSelect panics from non-total sort comparators and gas-limit underflow. Both are fixed, and comparator total order is covered by unit tests, while the step cost ~6 minutes of the 30-minute calibnet check budget. --- scripts/mpool_select_killer.rb | 29 --------------------------- scripts/tests/calibnet_other_check.sh | 4 ---- 2 files changed, 33 deletions(-) delete mode 100755 scripts/mpool_select_killer.rb diff --git a/scripts/mpool_select_killer.rb b/scripts/mpool_select_killer.rb deleted file mode 100755 index fb9541e691c0..000000000000 --- a/scripts/mpool_select_killer.rb +++ /dev/null @@ -1,29 +0,0 @@ -#!/usr/bin/env ruby -# frozen_string_literal: true - -# This script was used to reproduce multiple panic bugs in Forest's `Filecoin.MpoolSelect` RPC method. -# It accepts JSON chain list from the standard input, i.e., the output of `forest-cli chain head --format json -n 150` -# and sends requests to the Filecoin node's RPC endpoint with the given tipsets. -# -# https://github.com/ChainSafe/forest/issues/4490. -# https://blog.rust-lang.org/2024/09/05/Rust-1.81.0/#new-sort-implementations - -require 'json' -require 'http' - -input = $stdin.read -data = JSON.parse(input) - -data.map { |item| item['cids'].map { |cid| { '/' => cid } } }.each do |tipset| - puts tipset.inspect - HTTP.post( - 'http://localhost:2345/rpc/v0', - headers: { 'Content-Type' => 'application/json' }, - json: { - jsonrpc: '2.0', - method: 'Filecoin.MpoolSelect', - params: [tipset, 0.8], - id: 1 - } - ) -end diff --git a/scripts/tests/calibnet_other_check.sh b/scripts/tests/calibnet_other_check.sh index 9f6115c04166..5e59d503ffb9 100755 --- a/scripts/tests/calibnet_other_check.sh +++ b/scripts/tests/calibnet_other_check.sh @@ -67,10 +67,6 @@ if ! grep -q "$bundle_cid" "$manifest_path"; then exit 1 fi -echo "Regression testing mempool select" -gem install http --user-install -$FOREST_CLI_PATH chain head --format json -n 1000 | scripts/mpool_select_killer.rb - echo "Test subcommand: state compute (batch)" head_epoch=$($FOREST_CLI_PATH chain head --format json | jq ".[0].epoch") if ! [[ "$head_epoch" =~ ^[0-9]+$ ]]; then