- No bass line transcription yet. Use it when you want to check the groove before rehearsal.
+
+ {fillTranslation(t("grooveMapEmpty"), { role: roleName })}
);
}
@@ -68,13 +94,13 @@ function GrooveMapComponent({ notes, isLoading }: GrooveMapProps) {
className="relative mt-4 overflow-x-auto rounded-lg border border-cyan-200/15 bg-slate-950/80 p-4 shadow-inner shadow-cyan-950/50 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-cyan-300"
role="region"
tabIndex={0}
- aria-label="Bass transcription groove map"
+ aria-label={fillTranslation(t("grooveMapRegionLabel"), { role: roleName })}
>
- Transcription complete. {renderedNotes.length} notes analyzed.
+ {fillTranslation(t("grooveMapComplete"), { count: renderedNotes.length })}
- {renderedNotes.length} notes mapped for rehearsal
+ {fillTranslation(t("grooveMapMapped"), { count: renderedNotes.length })}
@@ -95,20 +121,26 @@ function GrooveMapComponent({ notes, isLoading }: GrooveMapProps) {
const leftPercent = (note.onset / maxTime) * 100;
const widthPercent = ((note.offset - note.onset) / maxTime) * 100;
const noteLabel = `${note.pitch} (${note.onset.toFixed(2)}s - ${note.offset.toFixed(2)}s)`;
+ const isEntrance = entranceOnset !== undefined && note.onset === entranceOnset;
return (
- {noteLabel}
+ {isEntrance ? fillTranslation(t("grooveMapEntranceAnnouncement"), { note: noteLabel }) : noteLabel}
);
@@ -120,4 +152,4 @@ function GrooveMapComponent({ notes, isLoading }: GrooveMapProps) {
const GrooveMap = memo(GrooveMapComponent);
-export { GrooveMap };
+export { GrooveMap, maximumNoteOffset };
diff --git a/apps/desktop/src/features/workspace/Workspace.review.test.tsx b/apps/desktop/src/features/workspace/Workspace.review.test.tsx
new file mode 100644
index 000000000..a10f2d38e
--- /dev/null
+++ b/apps/desktop/src/features/workspace/Workspace.review.test.tsx
@@ -0,0 +1,726 @@
+import { readFileSync } from "node:fs";
+import { resolve } from "node:path";
+import { useState } from "react";
+import { flushSync } from "react-dom";
+import { fireEvent, render, screen } from "@testing-library/react";
+import { createDemoRehearsalSong, type RehearsalSong } from "@bandscope/shared-types";
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { GrooveMap } from "./GrooveMap";
+import { Workspace } from "./Workspace";
+
+/** Replace every copy of one rehearsal role so cross-section aggregation stays deterministic. */
+function replaceRole(song: ReturnType
, roleId: string, replace: (role: (typeof song.sections)[number]["roles"][number]) => (typeof song.sections)[number]["roles"][number]) {
+ song.sections = song.sections.map((section) => ({
+ ...section,
+ roles: section.roles.map((role) => (role.id === roleId ? replace(role) : role))
+ }));
+}
+
+describe("Workspace review regressions", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ vi.restoreAllMocks();
+ });
+
+ it("clears an armed setup when another song reuses the selected role id", () => {
+ const song = createDemoRehearsalSong();
+ const { rerender } = render( invalidate(event.target) : undefined}
+ onClickCapture={eventType === "click" ? (event) => invalidate(event.target) : undefined}
+ >
+
+ );
+ }
+ render( {}} />);
+ expect(screen.getByText(`${roleName} 파트를 확인하는 중...`)).toBeTruthy();
+ expect(screen.getByRole("button", { name: "취소" })).toBeTruthy();
+
+ rerender(;
+type TranscriptionNote = NonNullable[number];
/** Documented. */
function preventUnavailableAction(event: MouseEvent): void {
@@ -58,6 +60,32 @@ function nonBlankText(value: string | undefined): string | undefined {
return trimmed ? trimmed : undefined;
}
+/** Remove terminal sentence punctuation before embedding a cue in a larger sentence. */
+function sentenceFragment(value: string): string {
+ return value.replace(/[.!?。！？]+$/u, "").trimEnd();
+}
+
+/** Prefer the role's setup cue, then transpose, then simplification. */
+function roleSetupCue(role: RehearsalRole | undefined): string | undefined {
+ return nonBlankText(role?.setupNote) ?? nonBlankText(role?.transpositionPlan) ?? nonBlankText(role?.simplification);
+}
+
+/** Scroll and focus the setup card the player should follow next. */
+function focusRoleSetup(): void {
+ const node = document.getElementById("workspace-role-setup");
+ if (!(node instanceof HTMLElement)) {
+ return;
+ }
+ const prefersReducedMotion =
+ typeof window.matchMedia === "function" &&
+ window.matchMedia("(prefers-reduced-motion: reduce)").matches;
+ node.scrollIntoView({
+ behavior: prefersReducedMotion ? "auto" : "smooth",
+ block: "nearest"
+ });
+ node.focus();
+}
+
/** Documented. */
function safeProjectBootstrapSummary(value: ProjectBootstrapSummary | null): ProjectBootstrapSummary | null {
if (!value) {
@@ -121,6 +149,7 @@ const SongStructure = memo(function SongStructure({ sections, t }: { sections: R
/** Documented. */
export function Workspace({ song, sourceBootstrap = null, onSongUpdate }: WorkspaceProps) {
const [activeRole, setActiveRole] = useState(null);
+ const [armedSetup, setArmedSetup] = useState(null);
const t = useMemo(() => createTranslator(detectPreferredLocale()), []);
// Extract all unique roles from the song's sections
@@ -150,7 +179,33 @@ export function Workspace({ song, sourceBootstrap = null, onSongUpdate }: Worksp
if (!activeRole) return undefined;
return roleMap.get(activeRole);
}, [activeRole, roleMap]);
- const canTranscribeBass = activeRoleDetails?.name.toLowerCase().includes("bass") ?? false;
+ const activeRoleTranscription = useMemo(() => {
+ if (!activeRole) return undefined;
+ const notes: TranscriptionNote[] = [];
+ for (const section of song.sections) {
+ for (const role of section.roles) {
+ if (role.id !== activeRole || !role.transcription) continue;
+ for (const note of role.transcription) {
+ notes.push(note);
+ }
+ }
+ }
+ if (notes.length === 0) return undefined;
+ notes.sort((left, right) => left.onset - right.onset);
+ return notes;
+ }, [activeRole, song.sections]);
+ const firstNote = earliestAnalyzedNote(activeRoleTranscription);
+ const activeRoleRange = playableRange(
+ activeRoleDetails?.range.lowestNote,
+ activeRoleDetails?.range.highestNote
+ );
+ const roleRangeLow = activeRoleRange?.lowestNote;
+ const roleRangeHigh = activeRoleRange?.highestNote;
+ const setupCue = roleSetupCue(activeRoleDetails);
+ const setupSentenceCue = setupCue ? sentenceFragment(setupCue) : "";
+ const hasPlayableRange = activeRoleRange !== null;
+ const hasStartEvidence = Boolean(firstNote || hasPlayableRange);
+ const canArmTonightSetup = Boolean(setupCue && hasStartEvidence);
const firstRange = useMemo(() => firstRangeSqueeze(song, activeRole), [activeRole, song]);
const firstRangeCopy = firstRange
? fillRangeCopy(
@@ -225,6 +280,85 @@ export function Workspace({ song, sourceBootstrap = null, onSongUpdate }: Worksp
const roleTranspositionPlan =
nonBlankText(activeRoleDetails?.transpositionPlan) ??
nonBlankText(activeRoleDetails?.simplification);
+ const roleName = nonBlankText(activeRoleDetails?.name) ?? t("workspaceThisRole");
+ const setupUnavailableLabel = setupCue && !hasStartEvidence
+ ? t("workspaceSetupStartUnavailable")
+ : t("workspaceSetupUnavailable");
+ const setupActionLabel = !canArmTonightSetup
+ ? setupUnavailableLabel
+ : firstNote
+ ? fillTranslation(t("workspaceSetupActionWithNote"), {
+ role: roleName,
+ pitch: firstNote.pitch,
+ start: formatTimelineTime(firstNote.onset)
+ })
+ : fillTranslation(t("workspaceSetupActionWithRange"), {
+ role: roleName,
+ low: roleRangeLow!,
+ high: roleRangeHigh!
+ });
+ const setupAriaLabel = !canArmTonightSetup
+ ? setupUnavailableLabel
+ : firstNote
+ ? fillTranslation(t("workspaceSetupAriaWithNote"), {
+ role: roleName,
+ pitch: firstNote.pitch,
+ start: formatTimelineTime(firstNote.onset),
+ setup: setupSentenceCue
+ })
+ : fillTranslation(t("workspaceSetupAriaWithRange"), {
+ role: roleName,
+ low: roleRangeLow!,
+ high: roleRangeHigh!,
+ setup: setupSentenceCue
+ });
+ const setupStatus = firstNote
+ ? fillTranslation(t("workspaceSetupArmedWithNote"), {
+ role: roleName,
+ pitch: firstNote.pitch,
+ start: formatTimelineTime(firstNote.onset),
+ setup: setupSentenceCue
+ })
+ : fillTranslation(t("workspaceSetupArmedWithRange"), {
+ role: roleName,
+ low: roleRangeLow!,
+ high: roleRangeHigh!,
+ setup: setupSentenceCue
+ });
+
+ // Activation belongs to this song/source and the exact setup/start evidence,
+ // not the role id alone. Unrelated progress edits preserve this identity.
+ const setupIdentity = JSON.stringify([
+ song.id,
+ sourceBootstrap?.projectId ?? null,
+ activeRole,
+ roleName,
+ setupCue ?? null,
+ firstNote ? [firstNote.pitch, firstNote.onset, firstNote.offset] : [roleRangeLow, roleRangeHigh]
+ ]);
+ const isSetupArmed = canArmTonightSetup && armedSetup === setupIdentity;
+ useEffect(() => {
+ setArmedSetup(null);
+ }, [setupIdentity]);
+
+ /** Arm tonight's setup and move focus to the setup card. */
+ const armTonightSetup = (): void => {
+ activateTonightSetup({
+ roleId: activeRole,
+ canArmTonightSetup,
+ /** Commit the current setup identity before moving focus to its card. */
+ onActivate: () => {
+ setArmedSetup(setupIdentity);
+ focusRoleSetup();
+ }
+ });
+ };
+
+ /** Keep the role board and armed setup on the same selected part. */
+ const handleRoleChange = (roleId: string | null): void => {
+ setActiveRole(roleId);
+ setArmedSetup(null);
+ };
/** Documented. */
const handleExportCueSheet = () => {
@@ -364,7 +498,7 @@ export function Workspace({ song, sourceBootstrap = null, onSongUpdate }: Worksp
@@ -376,8 +510,8 @@ export function Workspace({ song, sourceBootstrap = null, onSongUpdate }: Worksp
- Loop section
+ {t("workspaceLoopAction")}
Solo / mute others
- {canTranscribeBass ? (
+ {canArmTonightSetup ? (
- Transcribe Bass
+ {setupActionLabel}
) : (
- Transcribe Bass
+ {setupUnavailableLabel}
)}