Skip to content

JoSa comments on ULID.jl package - #3

Merged
jsappl merged 1 commit into
mainfrom
josa
Dec 3, 2025
Merged

jsappl merged 1 commit into
mainfrom
josa

Conversation

@jsappl

@jsappl jsappl commented Dec 2, 2025 •

Copy link
Copy Markdown
Contributor
  1. How is this implementation different from https://github.com/ararslan/ULID.jl and if so why do we need it?
  2. time() is in seconds but the docs state that

1.21e+24 unique ULIDs per millisecond

which would mean that we get tons of equal timestamps. Is this gonna be a problem for sorting then?

@jsappl
jsappl marked this pull request as ready for review December 2, 2025 14:17
@jsappl jsappl self-assigned this Dec 2, 2025
Comment thread src/ULID.jl Resolved
Comment thread src/ULID.jl Resolved
Comment thread src/ULID.jl Resolved
@antholzer

Copy link
Copy Markdown
Collaborator

The difference from the previous implementation is that it saves the ulids using UInt128 (same as julia UUIDs) instead of saving them as strings. In the spec it is denoted in the "Binary Implementation" column. We should probably add this to the README.

@antholzer

Copy link
Copy Markdown
Collaborator

time returns a Float64 so the integer part of it is in seconds but the fractional part gives as higher precision.

@jsappl
jsappl force-pushed the josa branch 2 times, most recently from 9a6c570 to 64a1d41 Compare December 3, 2025 11:17
@antholzer

Copy link
Copy Markdown
Collaborator

LGTM. Let's squash end merge this.

@jsappl
jsappl merged commit eaf7638 into main Dec 3, 2025
2 checks passed
@jsappl
jsappl deleted the josa branch December 3, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants