Skip to content

Scaling does not work any more #84

Description

@johann-petrak

This is probably a result of re-factoring so that the engine now decides on which corpus representation to use. But this means the engine has to know how to initialize the corpus representation.

Instead of passing around yet another parameter in all those methods, the idea is to set the scaling method as part of constructing the feature info or set it once the feature info has been created. The feature info gets passed to the corpus representation, so the scaling info could get set from there.
To make this clear we should remove the constructor parameter for the scaling method alltogether.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions