Skip to content

data(laptop): import Ammok laptops — 965 more (laptops 970->1935) - #103

Merged
Seungpyo1007 merged 4 commits into
mainfrom
data/import-staging
Jul 8, 2026
Merged

Seungpyo1007 merged 4 commits into
mainfrom
data/import-staging

Conversation

@Seungpyo1007

Copy link
Copy Markdown
Member

What & why

Second laptop dataset, extending the laptop category (added in PR #102) with 965 more laptops from Ammok/laptop_price_prediction (Hugging Face). These are mostly 2013–2018 machines — they complement the current-gen abhinavflac set rather than duplicate it (different eras, minimal overlap), and add brands the first set lacked (Toshiba, Razer, Xiaomi).

  • Added: 965 laptops (Dell 232, Lenovo 226, HP 179, Asus 122, Acer 83, Toshiba 39, MSI 34, Apple 17, and others)
  • All verified: false, integer ram_gb, weight_g from the source, brand FK required, cpu/gpu optional FK.
  • MSRP omitted — the source price column has an ambiguous currency/scale, so no price is injected rather than guessing.

Commits (each Refs #1): 3 brand-group data commits + surgical dump refresh.

Closes #1

Source

Ammok/laptop_price_prediction (HF). release_date year derived from the CPU generation (placeholder YYYY-01-01, source lacks dates); variant.source_row cites the CSV row.

Dump

Regenerated via TechEngine app.dump at submodule pin d1c3b0b. Laptops are unscored — only the new records + v1/laptops/index.json + manifest (laptops 970→1935) are committed; no churn on unchanged records.

Checklist

  • python -m app.validate — ✅ passed (full dataset)
  • python TechEngine/integrity_check.py data --strict — ✅ no hard anomalies
  • git diff --check — ✅ clean
  • Correct paths, kebab-case unique slugs (-ammok-<row> suffix, 0 collisions with abhinavflac), source_urls present

Second laptop dataset (Ammok/laptop_price_prediction, HF) — older
2013-2018 laptops complementing the abhinavflac current-gen set.
Dell and Lenovo lines with weight, RAM, storage, display, cpu/gpu
names. verified:false; MSRP omitted (ambiguous source currency).

Refs #1
More Ammok/laptop_price_prediction laptops (HP, Asus, Acer).
verified:false.

Refs #1
…ands

Remaining Ammok/laptop_price_prediction laptops (Toshiba, MSI, Apple,
Samsung, Microsoft, Razer, Xiaomi). verified:false.

Refs #1
Add the 965 Ammok laptop records to the static v1 dump (laptops
970->1935) and bump the manifest. Regenerated via TechEngine app.dump
at submodule pin d1c3b0b; only the new records + affected index +
manifest are committed.

Refs #1
@Seungpyo1007

Copy link
Copy Markdown
Member Author

🤖 Review — PASS

Check Command Result
Schema/self-check python -m app.validate ✅ passed (full dataset)
Integrity gate python TechEngine/integrity_check.py data --strict ✅ no hard anomalies
Whitespace git diff --check origin/main..HEAD ✅ none
Engine dump app.dump @ d1c3b0b ✅ 107,606 records incl. laptops:1935

Data-change summary

  • Added: 965 laptops (Ammok) · Modified/Deleted: 0
  • All verified:false; older 2013–2018 machines complementing the current-gen abhinavflac set. Brands added: Toshiba, Razer, Xiaomi. 0 slug collisions (-ammok- suffix).
  • MSRP omitted (ambiguous source currency) — no guessed prices.

Example records

  • data/laptop/acer/2013/acer-chromebook-14/acer-chromebook-14-ammok-691.json (Celeron 3855U, 4GB, 1.45kg)
  • Dell/Lenovo/HP 2016–2018 notebooks with weight, storage, cpu/gpu names.

Site build

  • No site/src changes. Surgical dump refresh — laptops 970→1935 + manifest only.

@Seungpyo1007

Copy link
Copy Markdown
Member Author

📊 Dataset stats (post-merge projection)

Metric Count
Total records 107,606
verified: true 10,028
verified: false 97,572
missing verified 6
Verified ratio 9.32%

laptops now 1,935 (abhinavflac 970 + Ammok 965) across 9 categories. Public laptop datasets are ~1k rows each; the two big ones are now imported, so laptops are near the public-data ceiling.

@Seungpyo1007
Seungpyo1007 merged commit 48971d3 into main Jul 8, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in TechAPI-Project Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Dataset changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

TechAPI dataset roadmap and status: all categories (1989-2026)

1 participant