data(laptop): import Ammok laptops — 965 more (laptops 970->1935) - #103
Merged
Merged
Conversation
Second laptop dataset (Ammok/laptop_price_prediction, HF) — older 2013-2018 laptops complementing the abhinavflac current-gen set. Dell and Lenovo lines with weight, RAM, storage, display, cpu/gpu names. verified:false; MSRP omitted (ambiguous source currency). Refs #1
More Ammok/laptop_price_prediction laptops (HP, Asus, Acer). verified:false. Refs #1
…ands Remaining Ammok/laptop_price_prediction laptops (Toshiba, MSI, Apple, Samsung, Microsoft, Razer, Xiaomi). verified:false. Refs #1
Member
Author
🤖 Review — PASS
Data-change summary
Example records
Site build
|
Member
Author
📊 Dataset stats (post-merge projection)
laptops now 1,935 (abhinavflac 970 + Ammok 965) across 9 categories. Public laptop datasets are ~1k rows each; the two big ones are now imported, so laptops are near the public-data ceiling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Second laptop dataset, extending the
laptopcategory (added in PR #102) with 965 more laptops from Ammok/laptop_price_prediction (Hugging Face). These are mostly 2013–2018 machines — they complement the current-gen abhinavflac set rather than duplicate it (different eras, minimal overlap), and add brands the first set lacked (Toshiba, Razer, Xiaomi).verified: false, integerram_gb,weight_gfrom the source, brand FK required, cpu/gpu optional FK.Commits (each
Refs #1): 3 brand-group data commits + surgical dump refresh.Closes #1
Source
Ammok/laptop_price_prediction(HF).release_dateyear derived from the CPU generation (placeholderYYYY-01-01, source lacks dates);variant.source_rowcites the CSV row.Dump
Regenerated via TechEngine
app.dumpat submodule pind1c3b0b. Laptops are unscored — only the new records +v1/laptops/index.json+ manifest (laptops 970→1935) are committed; no churn on unchanged records.Checklist
python -m app.validate— ✅ passed (full dataset)python TechEngine/integrity_check.py data --strict— ✅ no hard anomaliesgit diff --check— ✅ clean-ammok-<row>suffix, 0 collisions with abhinavflac),source_urlspresent