data(laptop): link cpu/gpu to the component catalog (1287 CPU + 509 GPU) - #104
Merged
Merged
Conversation
Resolve laptop cpu_name/gpu_name strings to existing CPU/GPU records and set the optional `cpu`/`gpu` FKs (1287 CPU + 509 GPU links across 1467 laptops). Matching is exact on the model code (e.g. 7200U, RTX 3050) with a family cross-check; integrated GPUs and unmatched chips stay name-only. Raw cpu_name/gpu_name are kept. Refs #1
Member
Author
🤖 Review — PASS
Change: 1,287 CPU + 509 GPU foreign keys added across 1,467 laptops (of 1,935). Exact model-code match (7200U, RTX 3050) + family cross-check; integrated GPUs and catalog-missing chips stay name-only. No new records. Dump limited to the 1,467 affected laptop detail files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Quality pass on the
laptopcategory: resolve each laptop'scpu_name/gpu_namestring to an existing CPU/GPU record and set the optionalcpu/gpuforeign keys. Laptop detail pages now link to the component catalog (e.g. a laptop → its Core i7-6700HQ and RTX 1060).cpu_name/gpu_nameare preserved.Commits (each
Refs #1): the FK-linking data commit + a surgical laptop-dump refresh.Closes #1
Checklist
python -m app.validate— ✅ passed (all cpu/gpu FKs resolve to real records)git diff --check— ✅ clean