data(smartphone,tablet): extract dimensions + wired charging from raw spec (3,118) - #114
Merged
Merged
Conversation
… spec
Parses Body.Dimensions (H x W x D mm -> {height_mm,width_mm,depth_mm}) and
Battery.Charging (wired W) from the stored raw_phones_2024 full-spec blob, for
records missing those fields. Deterministic parse of existing data.
dimensions +3,101; charging_wired_w +1,614 (across smartphone + tablet).
Refs #1
Member
Author
🤖 TechEngine · data validation
|
Member
Author
🤖 TechEngine · verify (Tier 0)Structured extraction from the record's own stored spec blob, not an import:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts two more structured fields from the full GSMArena spec blob (
raw_phones_2024) already stored on each record — deterministic parse, no new/external data.dimensions(+3,101) —Body.Dimensions"147 x 72.5 x 7.1 mm …"→{height_mm, width_mm, depth_mm}(matches the existing field shape).charging_wired_w(+1,614) —Battery.Charging"18W wired, QC2"→18.0(wireless/IP data absent for these mostly-older records, so those fields are untouched).Applies to smartphone + tablet; 3,118 records touched. All
verified: false. Validation passes. Dump regenerated — 3,118 changed detail pages.Closes #1