From b55153306976721001d8d253e8c36b725803e57b Mon Sep 17 00:00:00 2001 From: Nick Date: Tue, 8 Sep 2026 18:57:52 -0400 Subject: [PATCH 1/2] default width, speed, and mass properties to default to zero for dehacked isntead of using default decorate values. --- Core/Dehacked/DehackedApplier.cs | 5 +++++ RELEASENOTES.md | 1 + Tests/Unit/GameAction/Dehacked/DefaultFlags.cs | 18 +++++++++++++++++- 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/Core/Dehacked/DehackedApplier.cs b/Core/Dehacked/DehackedApplier.cs index 71e348673..ba81da3e1 100644 --- a/Core/Dehacked/DehackedApplier.cs +++ b/Core/Dehacked/DehackedApplier.cs @@ -961,6 +961,11 @@ private EntityDefinition GetNewActorDefinition(int index, EntityDefinitionCompos // This wasn't an option in the original game, needs to be applied to all potential projectile spawns. definition.Flags.SetRandomizeProjectile(); definition.Properties.Height = 0; + definition.Properties.Radius = 0; + definition.Properties.Health = 0; + definition.Properties.Mass = 0; + definition.Properties.MonsterMovementSpeed = 0; + definition.Properties.MissileMovementSpeed = 0; composer.Add(definition); m_dehacked.DefinitionLookup[index] = definition; return definition; diff --git a/RELEASENOTES.md b/RELEASENOTES.md index 1b32c1be2..68019d966 100644 --- a/RELEASENOTES.md +++ b/RELEASENOTES.md @@ -29,6 +29,7 @@ - Fix status bar uses ammo condition. - Fix BufferSubData call that could write out of bounds on GPU resulting in corrupted/missing walls. - Fix rendering issue with lines when changing transfer heights views. +- Fix width, speed, and mass properties to default to zero for dehacked isntead of using default decorate values. ## Misc: - Use DrawArraysInstanced instead of geometry shader for sprite rendering (allows for MacOS support). diff --git a/Tests/Unit/GameAction/Dehacked/DefaultFlags.cs b/Tests/Unit/GameAction/Dehacked/DefaultFlags.cs index 2edff6eb2..67ab58d94 100644 --- a/Tests/Unit/GameAction/Dehacked/DefaultFlags.cs +++ b/Tests/Unit/GameAction/Dehacked/DefaultFlags.cs @@ -29,6 +29,19 @@ public void NewDehackedThingDefaultRandomize() newDef2.Flags.RandomizeProjectile().Should().BeTrue(); } + [Fact(DisplayName = "New Dehacked thing has default properties")] + public void NewDehackedThingDefaultProperties() + { + var newDef = World.EntityManager.DefinitionComposer.GetByName("*deh/entity192"); + newDef.Should().NotBeNull(); + newDef.Properties.Height.Should().Be(0); + newDef.Properties.Radius.Should().Be(0); + newDef.Properties.Health.Should().Be(0); + newDef.Properties.Mass.Should().Be(0); + newDef.Properties.MissileMovementSpeed.Should().Be(0); + newDef.Properties.MonsterMovementSpeed.Should().Be(0); + } + private static readonly string Dehacked = @" Thing 191 (NewThing) @@ -38,5 +51,8 @@ Thing 191 (NewThing) Thing 192 (NewThing with height) ID # = 192 Height = 4521984 -Initial frame = 42069"";"; +Initial frame = 42069""; + +Thing 193 (DefaultThing) +ID # = 193"; } From ec973e58529df85ecdad3b5dcd59dbfb542693a6 Mon Sep 17 00:00:00 2001 From: Nick Date: Tue, 8 Sep 2026 18:58:39 -0400 Subject: [PATCH 2/2] typo --- RELEASENOTES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASENOTES.md b/RELEASENOTES.md index 68019d966..bdafe8dc9 100644 --- a/RELEASENOTES.md +++ b/RELEASENOTES.md @@ -29,7 +29,7 @@ - Fix status bar uses ammo condition. - Fix BufferSubData call that could write out of bounds on GPU resulting in corrupted/missing walls. - Fix rendering issue with lines when changing transfer heights views. -- Fix width, speed, and mass properties to default to zero for dehacked isntead of using default decorate values. +- Fix width, speed, and mass properties to default to zero for dehacked instead of using default decorate values. ## Misc: - Use DrawArraysInstanced instead of geometry shader for sprite rendering (allows for MacOS support).