diff --git a/.agents/skills/code-review/SKILL.md b/.agents/skills/code-review/SKILL.md index 92c8a6d..b91c582 100644 --- a/.agents/skills/code-review/SKILL.md +++ b/.agents/skills/code-review/SKILL.md @@ -34,6 +34,11 @@ You MUST adhere to this form because it will be later used by automation to crea If the rule asks for a citation, put it in the `description` field. +To fetch the full diff use +```shell +git fetch origin && git diff origin/master...HEAD +``` + Below are rules you should check when reviewing the code. ### duplicate-code @@ -123,3 +128,7 @@ subprocess/os.system/os.popen runs a shell with concatenated or formatted user/e ### pointless-wrapper A new or changed function or method only forwards to another callable with the same arguments and return value, adding no conversion, validation, defaulting, error handling, or other logic. Only flag when call sites could invoke the inner callable directly, the wrapper does not implement an interface, protocol, or abstract method, and it is not a public re-export of a private or third-party symbol. + +### redundant-parameter + +All callers of a new or changed function, method or class pass the same value for the parameter such that a parameter can be deleted without affecting any behaviour of all callers. diff --git a/.template.yaml b/.template.yaml index 366f1b7..ef37602 100644 --- a/.template.yaml +++ b/.template.yaml @@ -1,6 +1,6 @@ # Autogenerated - DO NOT EDIT # Parameters of the project as generated from template -_commit: fcdbd3c +_commit: c1e44de _src_path: gh:kraysent/python-template package_name: uploader project_name: uploader diff --git a/AGENTS.md b/AGENTS.md index 22da2d9..47b76d5 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -82,4 +82,4 @@ from collections.abc import Sequence ### File changes -When moving files as part of a refactor of any kind prefer using `git mv` whenver possible instead of removing + adding. +When moving files as part of a refactor of any kind prefer using `git mv` whenever possible instead of removing + adding. diff --git a/uploader/task_registry.py b/uploader/task_registry.py index 5242661..ce2e9b0 100644 --- a/uploader/task_registry.py +++ b/uploader/task_registry.py @@ -72,8 +72,7 @@ def register_all_tasks() -> None: id="upload-structured-designation", title="Upload designations", description=( - "Evaluate a designation expression per row and upload names. " - "Normalization is done by the backend." + "Evaluate a designation expression per row and upload names. Normalization is done by the backend." ), additional_description=expression_syntax_help(), form_model=StructuredDesignationForm,