From cc87de512b5f1c131318066bd195bb68ebf6e378 Mon Sep 17 00:00:00 2001 From: InTheta <17220028+InTheta@users.noreply.github.com> Date: Tue, 17 Nov 2026 13:13:46 +0000 Subject: [PATCH] Show settled QA evidence in Delivery --- .../ManagedRunEvidence.browser.test.tsx | 82 +++++++++++-------- .../web/src/components/ManagedRunEvidence.tsx | 16 +++- apps/web/src/lib/managedRunDelivery.ts | 11 ++- 3 files changed, 75 insertions(+), 34 deletions(-) diff --git a/apps/web/src/components/ManagedRunEvidence.browser.test.tsx b/apps/web/src/components/ManagedRunEvidence.browser.test.tsx index 7f7ed6f9c4ae5..e1143dca415b6 100644 --- a/apps/web/src/components/ManagedRunEvidence.browser.test.tsx +++ b/apps/web/src/components/ManagedRunEvidence.browser.test.tsx @@ -15,39 +15,39 @@ vi.mock(import("~/state/entities"), async (original) => ({ ref?.threadId === "mcp:launch:known" ? ({ threadId: ref.threadId } as never) : null, })); -it("links an operator wait to the locally known worker and preserves unknown evidence", async () => { - const run: ManagedRun = { - version: 1, - runId: "00000000-0000-0000-0000-000000000000", - ticket: "fixture", - revision: "a".repeat(64), - status: "approved", - brief: { - workspaceId: "fixture", - repository: "lab/fixture", - baseSha: "b".repeat(40), - scope: "Fixture", - tokens: 100, +const run: ManagedRun = { + version: 1, + runId: "00000000-0000-0000-0000-000000000000", + ticket: "fixture", + revision: "a".repeat(64), + status: "approved", + brief: { + workspaceId: "fixture", + repository: "lab/fixture", + baseSha: "b".repeat(40), + scope: "Fixture", + tokens: 100, + }, + budget: { reserved: 100, used: null, remaining: null }, + stages: [ + { + stageId: "known", + role: "implementation", + status: "waiting_for_operator", + threadId: "mcp:launch:known", + providerInstanceId: "codex", + toolCalls: 0, + }, + { + stageId: "unknown", + role: "qa", + status: "queued", + threadId: "mcp:launch:unknown", + providerInstanceId: null, }, - budget: { reserved: 100, used: null, remaining: null }, - stages: [ - { - stageId: "known", - role: "implementation", - status: "waiting_for_operator", - threadId: "mcp:launch:known", - providerInstanceId: "codex", - toolCalls: 0, - }, - { - stageId: "unknown", - role: "qa", - status: "queued", - threadId: "mcp:launch:unknown", - providerInstanceId: null, - }, - ], - }; + ], +}; +it("links an operator wait to the locally known worker and preserves unknown evidence", async () => { await using screen = await render(); await expect.element(screen.getByText("implementation ยท Waiting for operator")).toBeVisible(); await expect @@ -57,3 +57,21 @@ it("links an operator wait to the locally known worker and preserves unknown evi await expect.element(screen.getByText("Tool calls 0")).toBeVisible(); await expect.element(screen.getByText("Tool calls Unknown")).toBeVisible(); }); + +it("shows the exact reviewed commit and reports a budget overrun separately from the verdict", async () => { + const reviewedSha = "715f6adc7f373f7e17fb2f41a2dc373e8785caca"; + await using screen = await render( + , + ); + const review = screen.getByRole("region", { name: "Independent QA" }); + await expect.element(review.getByText("Passed")).toBeVisible(); + await expect.element(review.getByText(reviewedSha)).toBeVisible(); + await expect.element(review.getByText("Operator", { exact: true })).toBeVisible(); + await expect.element(review.getByText("Token budget exceeded")).toBeVisible(); +}); diff --git a/apps/web/src/components/ManagedRunEvidence.tsx b/apps/web/src/components/ManagedRunEvidence.tsx index 34ac3b809b64f..15668be33013c 100644 --- a/apps/web/src/components/ManagedRunEvidence.tsx +++ b/apps/web/src/components/ManagedRunEvidence.tsx @@ -29,7 +29,7 @@ function formatCount(value: number | null): string { } export function ManagedRunEvidence({ run }: { run: ManagedRun }) { - const { brief, budget } = run; + const { brief, budget, qa } = run; const fields = [ ["Run ID", run.runId], ["Status", run.status], @@ -58,6 +58,20 @@ export function ManagedRunEvidence({ run }: { run: ManagedRun }) { ))} + {qa && ( +
+

Independent QA

+
+
Verdict
+
{qa.verdict === "pass" ? "Passed" : "Failed"}
+
Reviewed commit
+
{qa.reviewedSha}
+
Recorded by
+
{qa.source === "operator" ? "Operator" : "Provider"}
+
+ {qa.budgetExceeded &&

Token budget exceeded

} +
+ )}

Stages

{run.stages.length === 0 ? (

No stages recorded.

diff --git a/apps/web/src/lib/managedRunDelivery.ts b/apps/web/src/lib/managedRunDelivery.ts index 439d90e1128df..fd6efc1ec70f2 100644 --- a/apps/web/src/lib/managedRunDelivery.ts +++ b/apps/web/src/lib/managedRunDelivery.ts @@ -1,6 +1,7 @@ import * as Schema from "effect/Schema"; const uuid = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/; +const CommitSha = Schema.String.check(Schema.isPattern(/^[0-9a-f]{40}$/)); const Tokens = Schema.Int.check(Schema.isBetween({ minimum: 0, maximum: Number.MAX_SAFE_INTEGER })); const ManagedRun = Schema.Struct({ version: Schema.Literal(1), @@ -11,7 +12,7 @@ const ManagedRun = Schema.Struct({ brief: Schema.Struct({ workspaceId: Schema.String, repository: Schema.String, - baseSha: Schema.String.check(Schema.isPattern(/^[0-9a-f]{40}$/)), + baseSha: CommitSha, scope: Schema.String, tokens: Tokens, }), @@ -20,6 +21,14 @@ const ManagedRun = Schema.Struct({ used: Schema.NullOr(Tokens), remaining: Schema.NullOr(Tokens), }), + qa: Schema.optionalKey( + Schema.Struct({ + reviewedSha: CommitSha, + verdict: Schema.Literals(["pass", "fail"]), + source: Schema.Literals(["provider", "operator"]), + budgetExceeded: Schema.Boolean, + }), + ), stages: Schema.Array( Schema.Struct({ stageId: Schema.String,