Repository navigation
Conversation
I see no reason to allow mutating the fields. The implementation does not require it, and I think the fields are not a public interface. Making the fields `const` allows the Julia compiler/optimizer more freedom when reasoning about code that involves `BinaryHeap` values. NB: for the case when the subtype of `Ordering` is zero bytes wide, it would make more sense to just change `mutable struct` into `struct`. While the order is often of singleton type, that is not always the case. Thus this change is conservative, going for the straight improvement while avoiding a trade off. If necessary, it is possible to change to just `struct BinaryHeap` after this change is merged. Cross-reference issue JuliaCollections#988. Corresponding PR to the BinaryHeaps package: * SciML/BinaryHeaps.jl#27
Member
Author
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see no reason to allow mutating the fields. The implementation does not require it, and I think the fields are not a public interface.
Making the fields
constallows the Julia compiler/optimizer more freedom when reasoning about code that involvesBinaryHeapvalues.NB: for the case when the subtype of
Orderingis zero bytes wide, it would make more sense to just changemutable structintostruct. While the order is often of singleton type, that is not always the case. Thus this change is conservative, going for the straight improvement while avoiding a trade off. If necessary, it is possible to change to juststruct BinaryHeapafter this change is merged.Cross-reference issue #988.
Corresponding PR to the BinaryHeaps package: