Skip to content

refactor x < 1 error checks: optimized inlining and less duplication - #142

Merged
nsajko merged 1 commit into
JuliaCollections:masterfrom
nsajko:error-check-positive-int-refactor
Mar 4, 2026
Merged

nsajko merged 1 commit into
JuliaCollections:masterfrom
nsajko:error-check-positive-int-refactor

Conversation

@nsajko

@nsajko nsajko commented Mar 4, 2026 •

Copy link
Copy Markdown
Member

Split from PR #141.

@nsajko
nsajko marked this pull request as ready for review March 4, 2026 18:49
@codecov

codecov Bot commented Mar 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.08%. Comparing base (52e004e) to head (34f7349).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   90.72%   91.08%   +0.36%     
==========================================
  Files           1        1              
  Lines         399      404       +5     
==========================================
+ Hits          362      368       +6     
+ Misses         37       36       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nsajko

nsajko commented Mar 4, 2026 •

Copy link
Copy Markdown
Member Author

I see this as a straight improvement, and I do not see it as possibly controversial, and my other PR depends on this. So I will be bold and merge right away.

@nsajko
nsajko merged commit b4de694 into JuliaCollections:master Mar 4, 2026
5 checks passed
@nsajko
nsajko deleted the error-check-positive-int-refactor branch March 4, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant