From 004d0e385cb97eb010413d74216e960546e1a688 Mon Sep 17 00:00:00 2001 From: kragol Date: Fri, 28 Jul 2023 17:38:15 +0200 Subject: [PATCH 1/7] fixed bug with empty constructors fixes #85 --- src/PooledArrays.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PooledArrays.jl b/src/PooledArrays.jl index 1058f13..2d08f52 100644 --- a/src/PooledArrays.jl +++ b/src/PooledArrays.jl @@ -199,8 +199,8 @@ end PooledArray{T}(d, signed=signed, compress=compress) # Construct an empty PooledVector of a specific type -@inline PooledArray(t::Type) = PooledArray(Array(t,0)) -@inline PooledArray(t::Type, r::Type) = PooledArray(Array(t,0), r) +@inline PooledArray(t::Type) = PooledArray(Array{t}(undef,0)) +@inline PooledArray(t::Type, r::Type) = PooledArray(Array{t}(undef,0), r) ############################################################################## ## From 086df6c3d22db46a45c68c4fe72088eee5fd9e44 Mon Sep 17 00:00:00 2001 From: kragol Date: Fri, 28 Jul 2023 18:01:22 +0200 Subject: [PATCH 2/7] added tests for empty constructors --- test/runtests.jl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/runtests.jl b/test/runtests.jl index f205d73..218f944 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -15,6 +15,9 @@ end @testset "PooledArrays" begin @test eltype(PooledArray(Int[])) === Int + @test PooledArray(Int) == Int[] + @test PooledArray(Int,UInt64) == Int[] + a = rand(10) b = rand(10,10) c = rand(1:10, 1000) From c92e61b846fac89152e6791821b5fdc358263ed1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bogumi=C5=82=20Kami=C5=84ski?= Date: Fri, 28 Jul 2023 18:07:02 +0200 Subject: [PATCH 3/7] Update test/runtests.jl --- test/runtests.jl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/runtests.jl b/test/runtests.jl index 218f944..ceb6087 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -16,7 +16,9 @@ end @test eltype(PooledArray(Int[])) === Int @test PooledArray(Int) == Int[] - @test PooledArray(Int,UInt64) == Int[] + @test PooledArray(Int)) <: PooledVector{Int, UInt32} + @test PooledArray(Int, UInt64) == Int[] + @test PooledArray(Int, UInt64)) <: PooledVector{Int, UInt64} a = rand(10) b = rand(10,10) From e53664c1c2287e71a0dbaebad12ba1a92e76557d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bogumi=C5=82=20Kami=C5=84ski?= Date: Fri, 28 Jul 2023 18:08:57 +0200 Subject: [PATCH 4/7] Update test/runtests.jl --- test/runtests.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/runtests.jl b/test/runtests.jl index ceb6087..a182efe 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -16,9 +16,9 @@ end @test eltype(PooledArray(Int[])) === Int @test PooledArray(Int) == Int[] - @test PooledArray(Int)) <: PooledVector{Int, UInt32} + @test PooledArray(Int) <: PooledVector{Int, UInt32} @test PooledArray(Int, UInt64) == Int[] - @test PooledArray(Int, UInt64)) <: PooledVector{Int, UInt64} + @test PooledArray(Int, UInt64) <: PooledVector{Int, UInt64} a = rand(10) b = rand(10,10) From fe23cfd665470b3e3b10ac3c2c61087a31a9cbd9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bogumi=C5=82=20Kami=C5=84ski?= Date: Fri, 28 Jul 2023 18:11:44 +0200 Subject: [PATCH 5/7] Update test/runtests.jl --- test/runtests.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/runtests.jl b/test/runtests.jl index a182efe..7ceadd4 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -16,9 +16,9 @@ end @test eltype(PooledArray(Int[])) === Int @test PooledArray(Int) == Int[] - @test PooledArray(Int) <: PooledVector{Int, UInt32} + @test PooledArray(Int) isa PooledVector{Int, UInt32} @test PooledArray(Int, UInt64) == Int[] - @test PooledArray(Int, UInt64) <: PooledVector{Int, UInt64} + @test PooledArray(Int, UInt64) isa PooledVector{Int, UInt64} a = rand(10) b = rand(10,10) From ed569b565f486c62c8c0a55690cba77f308393b0 Mon Sep 17 00:00:00 2001 From: Jacob Quinn Date: Sat, 3 Oct 2026 15:59:01 -0600 Subject: [PATCH 6/7] Use the supported Actions cache service for CI Refresh the retired cache integration so the empty constructor fix can be checked on the current Julia matrix. AI disclosure: This work was prepared with assistance from OpenAI Codex. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 28eb529..9d8f074 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -32,7 +32,7 @@ jobs: with: version: ${{ matrix.version }} arch: ${{ matrix.arch }} - - uses: actions/cache@v1 + - uses: actions/cache@v4 env: cache-name: cache-artifacts with: From b319fcaad6f2fa50ecfe4f974194eae9f34144e9 Mon Sep 17 00:00:00 2001 From: Jacob Quinn Date: Sat, 3 Oct 2026 16:12:47 -0600 Subject: [PATCH 7/7] Restore coverage uploads in CI The legacy uploader reports authentication failures without failing CI. Use the supported uploader, GitHub OIDC for repository jobs, and tokenless public fork uploads. Fail the coverage step when an upload fails. AI disclosure: This work was prepared with assistance from OpenAI Codex. --- .github/workflows/ci.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9d8f074..7132b73 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,6 +9,9 @@ on: tags: '*' jobs: test: + permissions: + contents: read + id-token: write name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }} runs-on: ${{ matrix.os }} strategy: @@ -47,9 +50,12 @@ jobs: env: JULIA_NUM_THREADS: 4 - uses: julia-actions/julia-processcoverage@v1 - - uses: codecov/codecov-action@v1 + - uses: codecov/codecov-action@v5 with: - file: lcov.info + files: lcov.info + # Public fork pull requests use tokenless upload; repository jobs use OIDC. + use_oidc: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository }} + fail_ci_if_error: true # docs: # name: Documentation # runs-on: ubuntu-latest