Repository navigation
feat: fault topology as a button, with the pair direction from geometry - #144
Open
lachlangrose wants to merge 4 commits into
Open
lachlangrose wants to merge 4 commits into
lachlangrose wants to merge 4 commits into
Conversation
…on from geometry - The "Calculate topology" button in step 3 runs the calculation with the fault layer and name field from the data manager. It shows the result in a message bar on the page. No dialog opens. The button is disabled until the layer and the field are set. - Remove FaultTopologyWidget, its .ui file and launchers.FAULT_TOPOLOGY. The toolbar action stays and calls the same function. - Set each pair as (abutting fault, other fault) from the trace geometry. The map2loop table has no direction. A pair without a direction is left as NONE and listed in the message bar. - Keep the layer order of the faults, and keep relationships set by the user when the topology is calculated again.
- Record the pairs that the button set. On the next run, remove each of them that the user did not change, then set the pairs again. A pair that changed direction or is not found again is not kept. - Show the pairs of the user apart from the pairs without a direction. - Remove duplicate pairs (in either order) and self-pairs before the loop. - Use an end-point tolerance in map units that the user can set (step 3 and the plugin settings). An overshoot shorter than the tolerance abuts. If both traces end in the tolerance, the closer end abuts. - Give the geodataframe the CRS of the layer, and warn when the layer CRS uses degrees.
lachlangrose
added a commit
that referenced
this pull request
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Plan items 6.6 and 6.7.
6.6
FaultTopologyWidget, its.uifile andlaunchers.FAULT_TOPOLOGY. The toolbar action stays and uses the same function.loopstructural/main/fault_topology_calc.py. It has no widgets.6.7
Fault1,Fault2) has no direction.Fault1is only the later fault in the layer. The old code used that order as "abutting fault first".fault_pair_directionfinds the abutting fault from the trace geometry (the fault with an end point on the other trace). Pairs are written as(abutting, other).NONEand is listed in the message bar.Notes
feat/faults-only-model.Tests
tests/unit/test_fault_topology_calc.py: 15 tests pass.tests/qgis/test_fault_topology_button.py: not run. QGIS is not installed on my machine.🤖 Generated with Claude Code