chore(stellar): read asset metadata from controller and gated by FF and local config by stanleyyconsensys · Pull Request #493 · MetaMask/internal-snaps

stanleyyconsensys · 2026-10-21T10:40:29Z

Explanation

This PR does

Adds gated AssetsController metadata reads to the Stellar Snap, retaining snap-state fallback.

References

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

stanleyyconsensys · 2026-10-21T10:41:37Z

        (decimalPlaces && decimalPlaces > STELLAR_DECIMAL_PLACES) ||
        // > Max value
-        toSmallestUnit(amount).gt(new BigNumber(MAX_INT64).toString())
+        toSmallestUnit(amount).gt(MAX_INT64)


this is not related to this PR, but just a small refactor

very worthwhile!

stanleyyconsensys · 2026-10-21T10:43:30Z

+   * @returns Whether AssetsController reads are active.
   */
  async isMigrationEnabled(): Promise<boolean> {
+    if (!AppConfig.enableAssetMigration) {


make sure we dont read controller when we are not ready

why a specific configuration for it? why not rely on the feqature flag only?

just to gate when the PR merge, but a release ship, and someone turn on the FF when we dont wanna to read from controller

stanleyyconsensys · 2026-10-21T10:44:12Z

    if (isCoreClassicAsset(asset)) {
-      const { sponsor, limit } = asset.balance.metadata;
+      const { sponsor } = asset.balance.metadata;
+      const limit = normalizeCoreTrustlineLimit(asset.balance.metadata.limit);


this is try to resolve the inconsistency trustline limit, but we are not yet using this yet

Copilot

🟡 Changes recommended

Trustline normalization interprets whole-token display limits as stroops, understating them by a factor of 10,000,000.

1 open issue

Whole-token limits are misinterpreted as stroops · New

What changed in this PR

Adds gated AssetsController metadata reads to the Stellar Snap, retaining snap-state fallback.

Changes:

Wire controller access behind local configuration and a remote feature flag.
Add metadata mapping, SEP-41 fetching, and trustline-limit normalization.
Update tests, permissions, dependencies, and release notes.

File	Description
yarn.lock	Record new dependencies.
packages/stellar-wallet-snap/src/services/assets/AssetsService.ts	Gate migration reads locally.
packages/stellar-wallet-snap/src/services/assets/AssetsService.test.ts	Test migration gating.
packages/stellar-wallet-snap/src/services/assets/api.ts	Normalize trustline limits.
packages/stellar-wallet-snap/src/services/assets/api.test.ts	Test limit normalization.
packages/stellar-wallet-snap/src/services/asset-metadata/utils.ts	Accept supplied metadata icons.
packages/stellar-wallet-snap/src/services/asset-metadata/AssetMetadataService.ts	Read controller metadata with fallback.
packages/stellar-wallet-snap/src/services/asset-metadata/AssetMetadataService.test.ts	Cover metadata reads and fallback.
packages/stellar-wallet-snap/src/services/asset-metadata/__mocks__/assets.fixtures.ts	Supply the new service dependency.
packages/stellar-wallet-snap/src/context.ts	Wire controller providers and services.
packages/stellar-wallet-snap/src/config.ts	Default migration to disabled.
packages/stellar-wallet-snap/src/config.test.ts	Verify migration default.
packages/stellar-wallet-snap/src/api/integer.ts	Simplify maximum-amount comparison.
packages/stellar-wallet-snap/src/api/core-messenger.ts	Define controller messenger types.
packages/stellar-wallet-snap/snap.manifest.json	Request messenger permissions.
packages/stellar-wallet-snap/package.json	Add controller-related dependencies.
packages/stellar-wallet-snap/CHANGELOG.md	Document gated metadata reads.

_{Review effort: Balanced}

sonarqubecloud · 2026-10-21T10:52:01Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

🔵 Needs a closer look

The new messenger permissions and controller integration require host-level validation before approval.

No open issues 🎉

1 resolved since last review

Whole-token limits are misinterpreted as stroops

_{Review effort: Balanced}

ulissesferreira · 2026-10-21T11:07:32Z

praise: just like Tron's, very nice 👏

ulissesferreira · 2026-10-21T11:18:32Z

+### Added
+
+- Read asset metadata from AssetsController when feature flag `enableAssetMigration` and local flag `enableAssetMigration` is on ([#493](https://github.com/MetaMask/internal-snaps/pull/493))
+  - `enableAssetMigration` set to off.


question: is the goal of this sub-point to specify that by default the current changes make it off?

yea, we only switch to on, when full set of code ready to use controller
becoz in stellar we keep shipping new feature, i dont wanna this block / change any behavior when the migration is not ready

khanti42

LGTM just some nit comment

Also I see Stellar endowments getAssetMetadata but not AssetsController:getAssets. While Tron uses getAssets (forceUpdate / bypassServerCache) for post-tx freshness. If Stellar later needs live Core refresh after submit, we will need another endowment + adapter method.

stanleyyconsensys · 2026-10-21T11:30:25Z

LGTM just some nit comment

Also I see Stellar endowments getAssetMetadata but not AssetsController:getAssets. While Tron uses getAssets (forceUpdate / bypassServerCache) for post-tx freshness. If Stellar later needs live Core refresh after submit, we will need another endowment + adapter method.

not the same in Stellar
getAssets => get account asset
getAssetMetadata => get asset that even not own by this account (such as change trust)

we dont use forceUpdate / bypassServerCache, becoz horizon already return all data, we already using onChain data when build a txn

reading from controller for stellar is just for

get asset metadata
get asset balance for onAmountInput (thats all)

chore: prepare asset-metadata

6ddfdd9

stanleyyconsensys requested a balanced review from Copilot October 21, 2026 10:40

stanleyyconsensys added 2 commits October 21, 2026 18:40

Update snap.manifest.json

4e3eb89

Delete .horizon-fixture-state.json

dd84af1

Copilot started reviewing on behalf of stanleyyconsensys October 21, 2026 10:41

View session

stanleyyconsensys commented Oct 21, 2026

View reviewed changes

chore: lint + rename

94fe3bc

stanleyyconsensys commented Oct 21, 2026

View reviewed changes

Copilot AI reviewed Oct 21, 2026

View reviewed changes

Comment thread packages/stellar-wallet-snap/src/services/assets/api.ts

stanleyyconsensys added 2 commits October 21, 2026 18:46

Update CHANGELOG.md

67b7d94

Update CHANGELOG.md

6d48c21

stanleyyconsensys marked this pull request as ready for review October 21, 2026 10:48

stanleyyconsensys requested review from a team as code owners October 21, 2026 10:48

stanleyyconsensys deployed to default-branch October 21, 2026 10:48 — with GitHub Actions Active

stanleyyconsensys requested a balanced review from Copilot October 21, 2026 11:00

Copilot started reviewing on behalf of stanleyyconsensys October 21, 2026 11:01

View session

Copilot AI reviewed Oct 21, 2026

View reviewed changes

ulissesferreira reviewed Oct 21, 2026

View reviewed changes

khanti42 approved these changes Oct 21, 2026

View reviewed changes

Comment thread packages/stellar-wallet-snap/src/services/assets/api.ts

Comment thread packages/stellar-wallet-snap/src/services/asset-metadata/AssetMetadataService.ts

stanleyyconsensys enabled auto-merge October 21, 2026 12:09

stanleyyconsensys disabled auto-merge October 21, 2026 12:09

ulissesferreira approved these changes Oct 21, 2026

View reviewed changes

stanleyyconsensys added this pull request to the merge queue Oct 21, 2026

Merged via the queue into main with commit 5dd2c2a Oct 21, 2026
61 checks passed

stanleyyconsensys deleted the dev/stellar/asset-metadata-messenger branch October 21, 2026 12:48

Conversation

stanleyyconsensys commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stanleyyconsensys Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

sonarqubecloud Bot commented Oct 21, 2026

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khanti42 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stanleyyconsensys commented Oct 21, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stanleyyconsensys commented Oct 21, 2026 •

edited

Loading

stanleyyconsensys Oct 21, 2026 •

edited

Loading