From 2ff615d2e3f27db9ced19a77e8fc25d5d99ccd89 Mon Sep 17 00:00:00 2001 From: Interlap Date: Wed, 7 Oct 2026 22:58:53 +0200 Subject: [PATCH] signing setup: say in the help and README that a failed upload writes no profile Follow-up to #39: the help text and the README still said the build profile is written regardless of the upload. --- README.md | 5 +++-- cmd/builder/signing.go | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index cc24fe8..7bd2d95 100644 --- a/README.md +++ b/README.md @@ -530,8 +530,9 @@ create certificates. It then: The upload goes to the repository in `builder.json`, always. When it fails (no GitHub login, or a token that cannot write secrets) the error is printed and -the command carries on: files, values and the build profile are written and -shown anyway, and it exits non-zero at the end so a script notices. `--json` +the command carries on: files and values are written and shown anyway, but +the build profile is not, since `builder.json` must not claim a set the +repository does not have. It exits non-zero at the end so a script notices. `--json` reports the same in `github_upload` (`ok` or the error). **Extensions.** Every extension target (a widget, a share or notification diff --git a/cmd/builder/signing.go b/cmd/builder/signing.go index e814d8f..ad352d6 100644 --- a/cmd/builder/signing.go +++ b/cmd/builder/signing.go @@ -63,8 +63,9 @@ way when it is missing. The names and the values to put in them are always printed too, for Codemagic, Bitrise or a repository this login cannot write to. A failed upload -is reported and the command carries on — the files and the build profile are -written regardless — and it exits non-zero at the end.`, +is reported and the command carries on — the files are written and the values +printed, but the build profile is not, since builder.json must not claim a set +the repository does not have — and it exits non-zero at the end.`, RunE: runSigningSetup, }