Repository navigation
Commit 55003cc
Drop orphan draft references from the external-draft learning-rate note (#2978)
## What changed
The learning-rate note in `doc/external_draft.md`'s Reference
Configuration cited `1.0e-5 (4B)` and `2.0e-6 (0.8B)`. Those were the
**only** mention of either draft anywhere in the doc, so a reader meets
two rates for two models the page never introduces and cannot tell
which, if either, applies to them.
The Reference Configuration documents one pair: Llama-3.2-1B drafting
for Qwen3.8-27B at `2.0e-5`.
## Why not just delete the note
It carries the only "sweep for your own pair" guidance in the doc. L181
says a swapped draft wants a higher rate than a matched one, but never
says to sweep. So the note keeps the part that generalises and attaches
it to the rate this section actually documents.
```
> **Note on the learning rate:** 2.0e-5 was selected by sweeping against held-out
> acceptance, and it is specific to this draft, target and dump. The ordering between
> candidate rates does not transfer, so sweep for your own pair rather than carrying this
> value over.
```
## Testing
Documentation only, one file, no code. `pre-commit` passes including
`markdownlint-cli2`. Verified no `4B`, `0.8B`, `1.0e-5` or `2.0e-6`
reference remains in the doc.
Follow-up to #2688.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
<!-- coderabbit-ai-generated:v1 -->
## Summary by CodeRabbit
* **Documentation**
* Updated the learning-rate guidance to recommend evaluating settings
against held-out acceptance using your own draft and target.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Signed-off-by: Peter Hicks <phicks@nvidia.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>1 parent 5383d1a commit 55003cc
1 file changed
Lines changed: 2 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
240 | 240 | | |
241 | 241 | | |
242 | 242 | | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
| 243 | + | |
| 244 | + | |
247 | 245 | | |
248 | 246 | | |
249 | 247 | | |
| |||
0 commit comments