From f3051479ffe4dae69a3c5390a70c868d8c732ca8 Mon Sep 17 00:00:00 2001 From: jjackbrandt Date: Wed, 12 Aug 2026 21:00:36 +0000 Subject: [PATCH] ci: canonicalize replay proof task order --- .github/ci/test_validate_process_replay_release.py | 2 ++ .github/workflows/process_replay_refs.yaml | 6 ++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/ci/test_validate_process_replay_release.py b/.github/ci/test_validate_process_replay_release.py index 3a2a0726690e4c..730342e69d67c8 100644 --- a/.github/ci/test_validate_process_replay_release.py +++ b/.github/ci/test_validate_process_replay_release.py @@ -406,6 +406,8 @@ def test_workflow_binds_same_run_review_proof_and_opendbc_gitlink(): assert "workflow_run_id" in workflow assert "GITHUB_RUN_ID" in workflow assert "HEAD:opendbc_repo" in workflow + assert "expected_ids = sorted(trusted_ids)" in workflow + assert "len(set(trusted_ids)) != expected_tasks" in workflow assert "--expected-opendbc-sha" in workflow diff --git a/.github/workflows/process_replay_refs.yaml b/.github/workflows/process_replay_refs.yaml index 8f15a0db3d2c39..df53b0a30e04c1 100644 --- a/.github/workflows/process_replay_refs.yaml +++ b/.github/workflows/process_replay_refs.yaml @@ -584,9 +584,11 @@ jobs: raise SystemExit(f'missing review proof {results_path}') results = json.loads(results_path.read_text(encoding='utf-8')) trusted = json.loads(Path(os.environ['TRUSTED_INVENTORY_PATH']).read_text(encoding='utf-8')) - expected_ids = trusted.get('task_ids') - if not isinstance(expected_ids, list) or len(expected_ids) != expected_tasks: + trusted_ids = trusted.get('task_ids') + if (not isinstance(trusted_ids, list) or len(trusted_ids) != expected_tasks + or len(set(trusted_ids)) != expected_tasks): raise SystemExit('trusted active task inventory is invalid') + expected_ids = sorted(trusted_ids) if results.get('schema_version') != 1 or results.get('inventory') != 'active': raise SystemExit('review proof requires schema_version=1 and inventory=active') if results.get('tested_commit') != source_sha or results.get('ref_commit') != source_sha: