fix: avoid stale PostgreSQL catalog cleanup

Author: TonisOrmisson

src/openstatspec/sql/wide.py

@@ -1550,6 +1550,11 @@ def _compensate_catalog_initialization(
             ))
 
 
+def _requires_compensating_catalog_cleanup(profile_name: str) -> bool:
+    """Only PostgreSQL rolls back catalog DDL without stale compensation."""
+    return profile_name != "postgresql"
+
+
 def _catalog_residual_inventory(
     engine: Any, *, before_tables: set[str],
     before_columns: Mapping[str, set[str]],
@@ -1709,14 +1714,18 @@ def initialize_wide_catalog(
                     pre_dolt_state, post_dolt_state, phase="catalog initialization",
                 )
             except Exception as install_error:
-                try:
-                    with connection.begin():
-                        _compensate_catalog_initialization(
-                            connection, metadata=metadata, before_tables=before_tables,
-                            before_columns=before_columns, normative=normative,
-                            legacy=legacy,
-                        )
-                except Exception as cleanup_error:
+                cleanup_error = None
+                if _requires_compensating_catalog_cleanup(profile.name):
+                    try:
+                        with connection.begin():
+                            _compensate_catalog_initialization(
+                                connection, metadata=metadata, before_tables=before_tables,
+                                before_columns=before_columns, normative=normative,
+                                legacy=legacy,
+                            )
+                    except Exception as error:
+                        cleanup_error = error
+                if cleanup_error is not None:
                     inventory = _catalog_residual_inventory(
                         engine, before_tables=before_tables, before_columns=before_columns,
                     )

tests/test_catalog_lifecycle.py

@@ -7,7 +7,9 @@
 import openstatspec
 import openstatspec.sql.wide as wide
 from openstatspec.core import UnsupportedOperationError
-from openstatspec.sql.profiles import MYSQL, TargetCapabilityExceededError, preflight
+from openstatspec.sql.profiles import (
+    MYSQL, POSTGRESQL, TargetCapabilityExceededError, preflight,
+)
 from openstatspec.sql.wide import (
     ImportRecoveryError,
     _bounded_batches,
@@ -514,3 +516,23 @@ def invalidate(self):
         "commit",
     ]
 
+def test_postgresql_initializer_relies_on_transaction_rollback(tmp_path, monkeypatch):
+    path = tmp_path / "postgresql-rollback.sqlite"
+
+    def fail_migration(*_args, **_kwargs):
+        raise RuntimeError("injected catalog migration failure")
+
+    def compensation_must_not_run(*_args, **_kwargs):
+        raise AssertionError("PostgreSQL must not use stale DDL compensation")
+
+    monkeypatch.setattr(
+        wide, "effective_profile", lambda _url, **_kwargs: (POSTGRESQL, {}),
+    )
+    monkeypatch.setattr(wide, "_migrate_catalog_columns", fail_migration)
+    monkeypatch.setattr(
+        wide, "_compensate_catalog_initialization", compensation_must_not_run,
+    )
+
+    with pytest.raises(RuntimeError, match="injected catalog migration failure"):
+        openstatspec.initialize_catalog(database_url=f"sqlite:///{path}")
+