Preflight physical table name collisions

Author: TonisOrmisson

src/openstatspec/sql/wide.py

@@ -117,6 +117,8 @@ def create_wide_dataset(
         metadata.create_all(connection, tables=[datasets, variable_catalog, multiple_response_catalog])
         if connection.execute(select(datasets.c.dataset_id).where(datasets.c.dataset_id == dataset_id)).first():
             raise ValueError(f"Dataset {dataset_id!r} already exists; imports never overwrite a dataset.")
+        if connection.execute(select(datasets.c.dataset_id).where(datasets.c.data_table == data_table.name)).first():
+            raise ValueError(f"Dataset ID {dataset_id!r} collides with an existing physical data-table name; import was not started.")
         data_table.create(connection)
         materialized = [{"__case_ordinal": ordinal, **row} for ordinal, row in enumerate(rows, start=1)]
         connection.execute(insert(datasets).values(

tests/test_sav_sqlite.py

@@ -71,3 +71,17 @@ def test_validation_rejects_catalog_type_mismatch(tmp_path) -> None:
     connection.commit()
     with pytest.raises(ValueError, match="String variable"):
         openstatspec.validate(database_url=database, dataset_id="fixture")
+
+
+def test_import_rejects_physical_table_name_collision_without_partial_catalog(tmp_path) -> None:
+    source = tmp_path / "fixture.sav"
+    database_path = tmp_path / "dataset.sqlite"
+    database = f"sqlite:///{database_path}"
+    pyreadstat.write_sav(pd.DataFrame({"answer": [1.0]}), source)
+    openstatspec.import_sav(source, database_url=database, dataset_id="wave-1")
+
+    with pytest.raises(ValueError, match="collides"):
+        openstatspec.import_sav(source, database_url=database, dataset_id="wave 1")
+
+    connection = sqlite3.connect(database_path)
+    assert connection.execute("select dataset_id from dataset_catalog").fetchall() == [("wave-1",)]