From 803e7d038b7c321408515362342499fef1ba093c Mon Sep 17 00:00:00 2001 From: Paul Mulligan Date: Sat, 12 Sep 2026 19:28:02 -0400 Subject: [PATCH] build: pin pnpm 10 via packageManager so Dependabot and CI agree Dependabot picks its own pnpm version when none is pinned and has started regenerating lockfiles with pnpm 11, which no longer reads pnpm.overrides from package.json. That drops the qs override from pnpm-lock.yaml, and CI's pnpm 9 then fails every frozen install with ERR_PNPM_LOCKFILE_CONFIG_MISMATCH (seen on PRs #120 and #126). Pin pnpm@10.34.5 in packageManager, which both Dependabot and pnpm/action-setup honor, and drop the hardcoded version input from the workflows since action-setup refuses to have both. pnpm 10 is the version that wrote the current lockfile and still reads the package.json overrides. Co-Authored-By: Claude Fable 5.1 --- .github/workflows/ci.yml | 10 ---------- .github/workflows/cross-browser-baselines.yml | 6 ------ .github/workflows/mutation.yml | 2 -- .github/workflows/release.yml | 2 -- package.json | 3 ++- 5 files changed, 2 insertions(+), 21 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7880cdb..59e96c1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -197,8 +197,6 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - with: - version: 9 - name: Install dependencies run: pnpm install --frozen-lockfile @@ -224,8 +222,6 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - with: - version: 9 - name: Install dependencies run: pnpm install --frozen-lockfile @@ -254,8 +250,6 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - with: - version: 9 - name: Install dependencies run: pnpm install --frozen-lockfile @@ -294,8 +288,6 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - with: - version: 9 - name: Install dependencies run: pnpm install --frozen-lockfile @@ -345,8 +337,6 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - with: - version: 9 - name: Install Playwright run: npx playwright install --with-deps chromium diff --git a/.github/workflows/cross-browser-baselines.yml b/.github/workflows/cross-browser-baselines.yml index 47db60f..1b89d79 100644 --- a/.github/workflows/cross-browser-baselines.yml +++ b/.github/workflows/cross-browser-baselines.yml @@ -72,8 +72,6 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - with: - version: 9 - name: Check for cross-browser baselines id: baselines @@ -190,8 +188,6 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - with: - version: 9 - name: Mark workspace safe for git in-container run: git config --global --add safe.directory "$GITHUB_WORKSPACE" @@ -280,8 +276,6 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - with: - version: 9 - name: Mark workspace safe for git in-container run: git config --global --add safe.directory "$GITHUB_WORKSPACE" diff --git a/.github/workflows/mutation.yml b/.github/workflows/mutation.yml index 6355bf7..4b7ea24 100644 --- a/.github/workflows/mutation.yml +++ b/.github/workflows/mutation.yml @@ -34,8 +34,6 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - with: - version: 9 - name: Install dependencies run: pnpm install --frozen-lockfile diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 1353397..403431c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -34,8 +34,6 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - with: - version: 9 - name: Install dependencies run: pnpm install --frozen-lockfile diff --git a/package.json b/package.json index 8018a0a..a338304 100644 --- a/package.json +++ b/package.json @@ -51,5 +51,6 @@ "overrides": { "qs": "^6.15.2" } - } + }, + "packageManager": "pnpm@10.34.5" }