From ef7a1d9a91f7b613d61730a22de259dd70bf8b79 Mon Sep 17 00:00:00 2001
From: asto <asto18089@126.com>
Date: Thu, 5 Nov 2026 13:49:50 +0800
Subject: [PATCH] fix(tui): let the todo item status default out of required
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The schema listed status among the required item fields, but the
executor reads a missing status as TodoStatus::Pending — 'leave status
out = new pending todo' is the tool's real contract, so the schema was
stricter than the execution semantics and a valid call shape was
declared invalid. status leaves required (content stays: an item
without text is not a todo) and the status description states the
default where the model reads it. Fork-distinct behavior change versus
the upstream schema (upstream pins content+status required); flagged
for the fork-modifications register.

Signed-off-by: asto <asto18089@126.com>
---
 crates/tui/src/tools/todo.rs | 48 ++++++++++++++++++++++++++++++++++--
 1 file changed, 46 insertions(+), 2 deletions(-)

diff --git a/crates/tui/src/tools/todo.rs b/crates/tui/src/tools/todo.rs
index 89e4727462..3fe384a9a7 100644
--- a/crates/tui/src/tools/todo.rs
+++ b/crates/tui/src/tools/todo.rs
@@ -281,10 +281,10 @@ impl ToolSpec for TodoWriteTool {
                             "status": {
                                 "type": "string",
                                 "enum": ["pending", "in_progress", "completed", "cancelled"],
-                                "description": "Task status"
+                                "description": "Task status. Defaults to pending when omitted."
                             }
                         },
-                        "required": ["content", "status"]
+                        "required": ["content"]
                     }
                 }
             },
@@ -581,6 +581,50 @@ mod tests {
         assert_eq!(TodoStatus::from_str("blocked"), None);
     }
 
+    #[test]
+    fn todo_item_status_is_optional_with_a_pending_default() {
+        // The executor reads a missing status as TodoStatus::Pending, so
+        // "leave status out = new pending todo" is the tool's real contract;
+        // requiring status made the schema stricter than the execution
+        // semantics. content stays required — an item without text is not a
+        // todo — and the schema states the default where the model reads it.
+        let schema = TodoWriteTool::new(new_shared_todo_list()).input_schema();
+        assert_eq!(
+            schema["properties"]["todos"]["items"]["required"],
+            json!(["content"]),
+            "status leaves required; content stays"
+        );
+        let status_description =
+            schema["properties"]["todos"]["items"]["properties"]["status"]["description"]
+                .as_str()
+                .unwrap_or_default();
+        assert!(
+            status_description
+                .to_ascii_lowercase()
+                .contains("defaults to pending"),
+            "the schema must state the default where the model reads it: {status_description}"
+        );
+    }
+
+    #[tokio::test]
+    async fn work_update_treats_a_missing_status_as_pending() {
+        let tool = TodoWriteTool::new(new_shared_todo_list());
+        let context = ToolContext::new(std::env::temp_dir());
+        let result = tool
+            .execute(
+                json!({"todos": [{ "content": "fresh todo without status" }]}),
+                &context,
+            )
+            .await
+            .expect("a status-less todo is the documented default path");
+        let metadata = result.metadata.expect("metadata");
+        assert_eq!(
+            metadata["task_updates"]["checklist"]["items"][0]["status"],
+            json!("pending"),
+            "the execution default is pending"
+        );
+    }
+
     #[tokio::test]
     async fn work_update_returns_canonical_task_update_metadata() {
         let tool = TodoWriteTool::new(new_shared_todo_list());