From ee63e6ae2c5aec2c07156ca91666d91d5ab57236 Mon Sep 17 00:00:00 2001 From: Max Claude Date: Fri, 13 Nov 2026 12:16:48 +0100 Subject: [PATCH] Pin MessagePack to 3.1.12 and keep build package versions only in Directory.Build.props - MessagePack: `3.*` -> `3.1.12`, the version restore already resolved. It is the newest stable 3.x on nuget.org (4.0.0 is only at rc.1). - Directory.Build.props: Nerdbank.GitVersioning 3.10.94, DotNet.ReproducibleBuilds 2.0.5, Microsoft.SourceLink.GitHub 10.0.404. These are the versions both csproj files forced through ``; those overrides are removed. - release.yml: the nbgv comment now points to Directory.Build.props. Resolved packages in obj/project.assets.json are unchanged for both projects. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/release.yml | 2 +- Directory.Build.props | 6 +++--- EvenBetterFastSim.Tests/EvenBetterFastSim.Tests.csproj | 5 ----- EvenBetterFastSim/EvenBetterFastSim.csproj | 8 +------- 4 files changed, 5 insertions(+), 16 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 0562951..e69097e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -39,7 +39,7 @@ jobs: shell: pwsh run: | $ErrorActionPreference = 'Stop' - dotnet tool install --global nbgv --version 3.10.94 # same as the Nerdbank.GitVersioning package in the csproj files + dotnet tool install --global nbgv --version 3.10.94 # same as the Nerdbank.GitVersioning package in Directory.Build.props $env:PATH = "$env:USERPROFILE\.dotnet\tools;$env:PATH" $semver = nbgv get-version --variable SemVer2 if ($LASTEXITCODE -ne 0 -or [string]::IsNullOrWhiteSpace($semver)) { throw "nbgv failed to produce a version" } diff --git a/Directory.Build.props b/Directory.Build.props index 2efcfec..d044ba1 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -9,8 +9,8 @@ - - - + + + diff --git a/EvenBetterFastSim.Tests/EvenBetterFastSim.Tests.csproj b/EvenBetterFastSim.Tests/EvenBetterFastSim.Tests.csproj index d4dfab3..fd68062 100644 --- a/EvenBetterFastSim.Tests/EvenBetterFastSim.Tests.csproj +++ b/EvenBetterFastSim.Tests/EvenBetterFastSim.Tests.csproj @@ -43,11 +43,6 @@ runtime; build; native; contentfiles; analyzers; buildtransitive - - - - -