From db22afc7a63193488d77fb85f4a52125770bb7d1 Mon Sep 17 00:00:00 2001 From: mattgoud Date: Thu, 27 Aug 2026 13:47:58 +0200 Subject: [PATCH 1/2] CI: pin PrestaShop 9.1.5 instead of the superseded 9.1.4 tag 9.1.5 is the last release of the 9.1 line: the 9.1.x branch was deleted from the core once it shipped, so nothing newer will come out of it. --- .github/workflows/php.yml | 4 ++-- tests/php/phpstan/{phpstan-9.1.4.neon => phpstan-9.1.5.neon} | 0 2 files changed, 2 insertions(+), 2 deletions(-) rename tests/php/phpstan/{phpstan-9.1.4.neon => phpstan-9.1.5.neon} (100%) diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml index e6f2ad2..57ee3d2 100644 --- a/.github/workflows/php.yml +++ b/.github/workflows/php.yml @@ -92,8 +92,8 @@ jobs: - { presta_version: '9.0.3', php_version: '8.1' } - { presta_version: '9.0.3', php_version: '8.4' } # PrestaShop 9.1.x and develop support PHP 8.1 up to 8.5 - - { presta_version: '9.1.4', php_version: '8.1' } - - { presta_version: '9.1.4', php_version: '8.5' } + - { presta_version: '9.1.5', php_version: '8.1' } + - { presta_version: '9.1.5', php_version: '8.5' } - { presta_version: 'develop', php_version: '8.1' } - { presta_version: 'develop', php_version: '8.5' } fail-fast: false diff --git a/tests/php/phpstan/phpstan-9.1.4.neon b/tests/php/phpstan/phpstan-9.1.5.neon similarity index 100% rename from tests/php/phpstan/phpstan-9.1.4.neon rename to tests/php/phpstan/phpstan-9.1.5.neon From f55375fadd926e8b372b56fd8caec86cf49a0d2c Mon Sep 17 00:00:00 2001 From: mattgoud Date: Thu, 27 Aug 2026 13:47:58 +0200 Subject: [PATCH 2/2] CI: add PrestaShop 9.2.x to the PHPStan matrix Same coverage as pagesnotfound and blockreassurance, which already had it. --- .github/workflows/php.yml | 4 +++- tests/php/phpstan/phpstan-9.2.x.neon | 15 +++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 tests/php/phpstan/phpstan-9.2.x.neon diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml index 57ee3d2..046de26 100644 --- a/.github/workflows/php.yml +++ b/.github/workflows/php.yml @@ -91,9 +91,11 @@ jobs: # PrestaShop 9.0.x supports PHP 8.1 up to 8.4 (8.5 is not supported) - { presta_version: '9.0.3', php_version: '8.1' } - { presta_version: '9.0.3', php_version: '8.4' } - # PrestaShop 9.1.x and develop support PHP 8.1 up to 8.5 + # PrestaShop 9.1.5, 9.2.x and develop support PHP 8.1 up to 8.5 - { presta_version: '9.1.5', php_version: '8.1' } - { presta_version: '9.1.5', php_version: '8.5' } + - { presta_version: '9.2.x', php_version: '8.1' } + - { presta_version: '9.2.x', php_version: '8.5' } - { presta_version: 'develop', php_version: '8.1' } - { presta_version: 'develop', php_version: '8.5' } fail-fast: false diff --git a/tests/php/phpstan/phpstan-9.2.x.neon b/tests/php/phpstan/phpstan-9.2.x.neon new file mode 100644 index 0000000..914a4e6 --- /dev/null +++ b/tests/php/phpstan/phpstan-9.2.x.neon @@ -0,0 +1,15 @@ +includes: + - %currentWorkingDirectory%/tests/php/phpstan/phpstan.neon + +parameters: + ignoreErrors: + # Framework / structural limitations that cannot be fixed in module code: + # - uninstallModule() calls parent::uninstall() through a closure rebound to the + # target module via Closure::bindTo(), a pattern PHPStan cannot statically resolve. + # - Cookie uses magic __get/__set, so its dynamic properties are undefined to PHPStan. + # - HookInterface mandates the constructor signature (Ps_Googleanalytics $module, Context), + # so $module must be stored even in hooks that never read it back. + - '#PrestaShop\\Module\\Ps_Googleanalytics\\Handler\\ModuleHandler::uninstallModule\(\) calls parent::uninstall\(\) but PrestaShop\\Module\\Ps_Googleanalytics\\Handler\\ModuleHandler does not extend any class.#' + - '#Access to an undefined property Cookie\:\:\$ga_admin_order.#' + - '#Access to an undefined property Cookie\:\:\$ga_admin_refund.#' + - '#Property PrestaShop\\Module\\Ps_Googleanalytics\\Hooks\\HookActionValidateOrder::\$module is never read, only written\.#'