Skip to content

[bug]1.21.1 NeoForge advancements are awarded immediately when joining a world #38

Description

@jim139129

Description

On Minecraft 1.21.1 with NeoForge, Create: TrainUtilities awards these advancements immediately after a player joins a world:

  • A first Draft!
  • Modern Age!
  • Component Warehouse
  • Is this the REALITY?

This happens even when the player has not obtained any TrainUtilities items.

Steps to Reproduce

  1. Install Create: TrainUtilities 3.1.0 on Minecraft 1.21.1 with NeoForge.
  2. Create or join a world with a new player.
  3. Observe the advancement notifications and server log.

Expected Behavior

Each advancement should only be awarded after the player obtains an item from its intended TrainUtilities item tag.

Actual Behavior

All four advancements are awarded during the initial inventory synchronization after joining the world.

Cause

The 1.21.1 advancement files still use the legacy tag item-predicate field. In 1.21.1, item tags must use the items field with a # prefix.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions