test(b01_q10): update test expectations for mapped DP codes 112 and 113

Author: Gargeesharmaa

roborock/data/b01_q10/b01_q10_code_mappings.py

@@ -101,13 +101,8 @@ class B01_Q10_DP(RoborockModeEnum):
     VOICE_VERSION = ("dpVoiceVersion", 108)
     ROBOT_COUNTRY_CODE = ("dpRobotCountryCode", 109)
     HEARTBEAT = ("dpHeartbeat", 110)
-    # NOTE: ss07 hardware also pushes data points 112 and 113 in its full status
-    # dump. They are absent from the official app's vacuum plugin and stayed 0
-    # across every observed state (docked/charging, segment cleaning, lifted-off-
-    # ground fault, returning to dock, dustbin removed), so their meaning is not
-    # yet known. They are intentionally left unmapped; ``decode_rpc_response``
-    # silently ignores unknown codes via ``from_code_optional``, so they do not
-    # produce "not a valid code" warnings. Map them here once identified.
+    UNKNOWN_112 = ("dpUnknown112", 112)
+    UNKNOWN_113 = ("dpUnknown113", 113)
     STATUS = ("dpStatus", 121)
     BATTERY = ("dpBattery", 122)
     FAN_LEVEL = ("dpFanLevel", 123)  # NOTE: typo "dpfunLevel" in source code

tests/data/test_code_mappings.py

@@ -36,18 +36,18 @@ def test_invalid_from_code_optional() -> None:
 
 
 def test_from_code_optional_does_not_warn(caplog: pytest.LogCaptureFixture) -> None:
-    """from_code_optional must silently return None for unknown codes.
-
-    Regression test: ss07 hardware pushes data points this library does not model
-    (e.g. DPs 112 and 113); resolving them via the optional lookup must not emit
-    the "not a valid code" warning that the strict ``from_code`` logs.
-    """
-    completed_warnings.discard("112 is not a valid code for B01_Q10_DP")
-    completed_warnings.discard("113 is not a valid code for B01_Q10_DP")
+    """Test that mapped codes return enum members and unmapped codes return None without warning spam."""
+    completed_warnings.discard("909090 is not a valid code for B01_Q10_DP")
+
+    # Mapped codes should now resolve to their respective enum members
+    assert B01_Q10_DP.from_code_optional(112) is B01_Q10_DP.UNKNOWN_112
+    assert B01_Q10_DP.from_code_optional(113) is B01_Q10_DP.UNKNOWN_113
+
+    # Truly unmapped codes should return None silently
     with caplog.at_level(logging.WARNING):
-        assert B01_Q10_DP.from_code_optional(112) is None
-        assert B01_Q10_DP.from_code_optional(113) is None
-    assert "not a valid code" not in caplog.text
+        assert B01_Q10_DP.from_code_optional(909090) is None
+
+    assert "is not a valid code for B01_Q10_DP" not in caplog.text
 
 
 def test_from_code_still_warns(caplog: pytest.LogCaptureFixture) -> None:

tests/protocols/test_b01_q10_protocol.py

@@ -140,17 +140,11 @@ def test_decode_invalid_rpc_payload(payload: bytes, expected_error_message: str)
 
 def test_decode_unknown_dps_code(caplog: pytest.LogCaptureFixture) -> None:
     """Unknown data points are dropped silently, without logging warnings.
-
-    ss07 hardware pushes DPs 112 and 113 (and occasionally others) that this
-    library does not model. They must be ignored without emitting "not a valid
-    code" warnings, which previously spammed the log on every status push.
     """
-    completed_warnings.discard("112 is not a valid code for B01_Q10_DP")
-    completed_warnings.discard("113 is not a valid code for B01_Q10_DP")
     completed_warnings.discard("909090 is not a valid code for B01_Q10_DP")
     message = RoborockMessage(
         protocol=RoborockMessageProtocol.RPC_RESPONSE,
-        payload=b'{"dps": {"909090": 123, "112": 0, "113": 0, "122": 100}}',
+        payload=b'{"dps": {"909090": 123, "122": 100}}',
         seq=12750,
         version=b"B01",
         random=97431,
@@ -164,6 +158,22 @@ def test_decode_unknown_dps_code(caplog: pytest.LogCaptureFixture) -> None:
     }
     assert "not a valid code" not in caplog.text
 
+def test_decode_mapped_112_113_dps() -> None:
+    """Verify newly mapped status codes 112 and 113 decode correctly."""
+    message = RoborockMessage(
+        protocol=RoborockMessageProtocol.RPC_RESPONSE,
+        payload=b'{"dps": {"112": 0, "113": 0}}',
+        seq=12751,
+        version=b"B01",
+        random=97431,
+        timestamp=1652547161,
+    )
+    decoded_message = decode_rpc_response(message)
+    assert decoded_message == {
+        B01_Q10_DP.UNKNOWN_112: 0,
+        B01_Q10_DP.UNKNOWN_113: 0,
+    }
+
 
 @pytest.mark.parametrize(
     ("command", "params"),