From 45757b859c26238ab00b3263e26de3b5491e43c1 Mon Sep 17 00:00:00 2001 From: Jay Fletcher <5743488+jayjfletcher@users.noreply.github.com> Date: Wed, 28 Oct 2026 09:11:32 -0400 Subject: [PATCH] Commit the spec records of finished jobs These spec folders were written untracked in the main checkout, before Ringside kept each spec in its job worktree and committed it with the job. Scratch files (PR, issue and comment drafts) are left out. Co-Authored-By: Claude Opus 5.5 (1M context) --- .../decisions.md | 57 +++++++++++++++++++ .../meta.yml | 7 +++ .../questions.yml | 1 + .../references.md | 5 ++ .../shape.md | 24 ++++++++ .../spec-review.md | 26 +++++++++ .../spec.md | 42 ++++++++++++++ .../standards.md | 7 +++ .../tasks.md | 15 +++++ .../verification.md | 39 +++++++++++++ .../decisions.md | 49 ++++++++++++++++ .../meta.yml | 10 ++++ .../questions.yml | 1 + .../references.md | 6 ++ .../shape.md | 25 ++++++++ .../spec-review.md | 15 +++++ .../spec.md | 40 +++++++++++++ .../standards.md | 5 ++ .../tasks.md | 16 ++++++ .../meta.yml | 6 ++ .../spec.md | 10 ++++ 21 files changed, 406 insertions(+) create mode 100644 docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/decisions.md create mode 100644 docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/meta.yml create mode 100644 docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/questions.yml create mode 100644 docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/references.md create mode 100644 docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/shape.md create mode 100644 docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/spec-review.md create mode 100644 docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/spec.md create mode 100644 docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/standards.md create mode 100644 docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/tasks.md create mode 100644 docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/verification.md create mode 100644 docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/decisions.md create mode 100644 docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/meta.yml create mode 100644 docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/questions.yml create mode 100644 docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/references.md create mode 100644 docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/shape.md create mode 100644 docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/spec-review.md create mode 100644 docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/spec.md create mode 100644 docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/standards.md create mode 100644 docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/tasks.md create mode 100644 docs/agent/specs/2026-10-28-0100-drop-paratest-conflict-pin/meta.yml create mode 100644 docs/agent/specs/2026-10-28-0100-drop-paratest-conflict-pin/spec.md diff --git a/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/decisions.md b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/decisions.md new file mode 100644 index 0000000..ab7534b --- /dev/null +++ b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/decisions.md @@ -0,0 +1,57 @@ +# Decisions + +## D-001 + +- Question: Create a GitHub issue for this fix (draft - Title - "Fix CI failure on setup-php 2.40.0 bump (PR #8)"; Problem - Dependabot PR #8 fails the P8.5 / L13.* / prefer-stable / ubuntu-latest job; Outcome - PR #8 checks go green, not merged; Out of scope - merging), or skip the ticket and fix the PR branch directly? +- Choice: Create the issue +- Rationale: none given (answered in RingMaster) +- Date: 2026-10-27 +- Raised by: ticket + +## D-002 + +- Question: Failing job is a PHPStan bootstrap error (missing Testbench bootstrap/cache/packages.php in a parallel worker), and PR #8's run is from 2026-10-15 while main has been green since. How should the job be fixed? +- Choice: Rebase PR #8 and re-run first, change only the workflow if it still fails +- Rationale: A campaign is also dropping Cortex's paratest conflict; if the rebased run fails on composer resolving paratest, wait for that PR rather than fixing it here. (answered in RingMaster) +- Date: 2026-10-28 +- Raised by: shape + +## D-003 + +- Question: If the rebased run still fails on the PHPStan bootstrap race, where should the workflow fix land? +- Choice: Open a separate PR against main with the fix, then rebase PR #8 onto it +- Rationale: none given (answered in RingMaster) +- Date: 2026-10-28 +- Raised by: spec-review + +## D-004 + +- Question: How many consecutive green runs of the previously failing P8.5 / L13.* / prefer-stable / ubuntu-latest job count as proof before the job reports 'no change needed'? +- Choice: Two consecutive green runs on the same head (re-run once) +- Rationale: none given (answered in RingMaster) +- Date: 2026-10-28 +- Raised by: spec-review + +## D-005 + +- Question: If Dependabot does not rebase PR #8 (comment ignored, PR closed or superseded), how should criterion 1 be satisfied? +- Choice: Rebase manually and push to the PR branch +- Rationale: none given (answered in RingMaster) +- Date: 2026-10-28 +- Raised by: spec-review + +## D-006 + +- Question: Approve the spec for Fix CI failure on Dependabot setup-php 2.40.0 bump as written (acceptance criteria 1-6 after the D-003..D-005 recheck)? +- Choice: Approve +- Rationale: none given (answered in RingMaster) +- Date: 2026-10-28 +- Raised by: approval + +## D-007 + +- Question: PR #8 is green on two consecutive CI runs with no repo file changes, but the local gate fails on main: KeenInCiTest reads a stale gitignored composer.lock, and ringside check reports stale generated files. Mark this job done, or hold it? +- Choice: Mark done and propose a follow-up task to fix the local gate drift +- Rationale: none given (answered in RingMaster) +- Date: 2026-10-28 +- Raised by: build diff --git a/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/meta.yml b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/meta.yml new file mode 100644 index 0000000..1485040 --- /dev/null +++ b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/meta.yml @@ -0,0 +1,7 @@ +id: 2026-10-27-1055-fix-setup-php-2-40-0-bump +title: Fix CI failure on Dependabot setup-php 2.40.0 bump +status: done +review_passes: 2 +created: 2026-10-27 +ticket: { provider: github, key: "#13", url: "https://github.com/Refactor-Circus/Cortex/issues/13" } +standards: {} diff --git a/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/questions.yml b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/questions.yml new file mode 100644 index 0000000..fe51488 --- /dev/null +++ b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/questions.yml @@ -0,0 +1 @@ +[] diff --git a/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/references.md b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/references.md new file mode 100644 index 0000000..8186ce6 --- /dev/null +++ b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/references.md @@ -0,0 +1,5 @@ +# References + +- `.github/workflows/tests.yml`: the only file PR #8 changes; the matrix is `P{php} / L{laravel} / {stability} / {os}`. +- Failed run: https://github.com/Refactor-Circus/Cortex/actions/runs/38800233800/job/116647049225 — PHPStan bootstrap fails on a missing Testbench `bootstrap/cache/packages.php`. +- Passing runs on main (for example 40451198391) show the same workflow green without the bump. diff --git a/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/shape.md b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/shape.md new file mode 100644 index 0000000..9188b4b --- /dev/null +++ b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/shape.md @@ -0,0 +1,24 @@ +# Fix CI failure on setup-php 2.40.0 bump — Shaping Notes + +Ticket: https://github.com/Refactor-Circus/Cortex/issues/13 + +## Scope + +Dependabot PR #8 (`shivammathur/setup-php` 2.37.2 → 2.40.0, one line in `.github/workflows/tests.yml`) has one red job: `P8.5 / L13.* / prefer-stable / ubuntu-latest`. Outcome: PR #8's checks go green. Out of scope: merging PR #8. + +## Decisions + +- D-001: GitHub issue created (answered in RingMaster). +- D-002: Rebase PR #8 and re-run first; change only the workflow if it still fails. If the rebased run fails on composer resolving paratest, wait for the campaign PR that drops Cortex's paratest conflict instead of fixing it here. + +## Context + +- The failing step is PHPStan, not setup-php: "Laravel framework bootstrap failed ... require(vendor/orchestra/testbench-core/laravel/bootstrap/cache/packages.php): Failed to open stream" in a parallel worker (run 38800233800, 2026-10-15). +- The other three jobs of that run (prefer-lowest on ubuntu and windows, prefer-stable on windows) passed. +- The PR run predates 2026-10-27; every `tests.yml` run on main and on the later branches since passed (latest on main 2026-10-27). PR #8 has not been re-run on current main. +- Leading hypothesis: a race creating Testbench's `bootstrap/cache/packages.php` across PHPStan parallel workers, not a setup-php regression. To confirm: rebase PR #8 (`@dependabot rebase`) and re-run; if it stays red, reproduce locally with `composer analyse`. +- The fix is a change to the PR branch or a workflow/PHPStan config tweak (for example, warm the Testbench package cache before PHPStan), not a Cortex source change. + +## Standards + +None of the local standards govern CI workflow files. The compat skill (`package-compatibility`) applies for the matrix. diff --git a/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/spec-review.md b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/spec-review.md new file mode 100644 index 0000000..483c102 --- /dev/null +++ b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/spec-review.md @@ -0,0 +1,26 @@ +# Spec review + +## Round 1 + +Changes to spec.md, and why: + +- Acceptance criteria extended to six. Criterion 1 now lists the evidence of the rebase (head SHA change, merge-base with main, run id) and notes Dependabot's reduced token; an unresponsive or closed PR is recorded and handled per the open question. +- Criterion 2 now requires the run URL, per-job results, an unconfirmed-race statement, and an unchanged one-line PR diff. +- Criterion 3 now requires reproducing or explaining the cause first, names the allowed files, defines the pass condition (all matrix jobs green, no "Failed to open stream ... packages.php" in the PHPStan log), and says what to do when a push is refused. Run counts and fix location are left to the open questions. +- Criterion 4 now names the paratest failure signature and ends with a blocked release and a resume note naming the campaign PR. +- New criterion 5 defines the end state for any other failure: no change, record on #13, release as failed. +- Criterion 6 (was 5) states the file boundary, checkable with `git diff --name-only`. +- Out of scope now excludes composer.json, other workflows, matrix changes and other Dependabot PRs. +- Risks now cover Dependabot ceasing to manage the branch after a human push, the `workflow` token scope, and a closed or superseded PR. +- Left unchanged on purpose: the four open questions (fix location, green run count for the P8.5 job, rebase fallback, full-matrix run count). + +## Pass 2: recheck of D-003, D-004, D-005 + +All three decisions had landed in the Addendum. The body still contradicted them, so spec.md was changed: + +- Criterion 1: manual rebase when Dependabot ignores the comment (D-005); for a manual rebase, the merge-base evidence is checked against the `main` tip at push time; a closed or superseded PR is recorded on #13 with no other change. +- Criterion 2: two consecutive green runs on the same head (D-004), with both run URLs on #13; a failed re-run is handled by criterion 3, 4 or 5. +- Criterion 3: the fix goes in a separate PR against `main` (D-003); the job is released as blocked with a resume note naming that PR, since merging it is the user's call; on resume, PR #8 is rebased and must pass twice. +- Criterion 6: checked per PR (PR #8 = one-line bump; fix PR = `tests.yml` and/or the PHPStan config). +- Risks: updated for two green runs, the stale branch after a manual rebase, and the `workflow` token scope on both pushes. +- Open questions: none. diff --git a/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/spec.md b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/spec.md new file mode 100644 index 0000000..e539a4a --- /dev/null +++ b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/spec.md @@ -0,0 +1,42 @@ +# Fix CI failure on setup-php 2.40.0 bump + +Ticket: https://github.com/Refactor-Circus/Cortex/issues/13 + +## Goal + +Dependabot PR #8 (`shivammathur/setup-php` 2.37.2 → 2.40.0) goes green, so a maintainer can merge it. Merging is not part of this job. + +## Acceptance criteria + +1. PR #8's branch is rebased onto current `main` (`@dependabot rebase`), and `tests.yml` runs on the rebased head. Evidence, recorded on issue #13: the PR head SHA changed, its merge-base equals the `main` tip when the comment was posted, and the run id of the `tests.yml` run on that head. The run executes under Dependabot's reduced token and secrets. If Dependabot ignores the comment, record that on #13 and rebase PR #8's branch manually onto `main` and push it (D-005); if it is closed or superseded, record that on #13 and make no other change. When the rebase is manual there is no comment, so the merge-base evidence is measured against the `main` tip at push time. +2. If every job of the run passes, including `P8.5 / L13.* / prefer-stable / ubuntu-latest`, and a single re-run of the workflow on the same head also passes every job (two consecutive green runs, D-004), no file changes: the PR diff is still the one-line setup-php bump, and the result is noted on issue #13 (D-002). The note includes both run URLs, the per-job results, and a statement that the race hypothesis is unconfirmed. If the re-run fails, treat it as the error that run shows (criterion 3, 4 or 5). +3. If the PHPStan bootstrap error ("Failed to open stream ... bootstrap/cache/packages.php") still occurs, first reproduce it locally (`composer analyse`) or explain the cause from the log, and record the cause on #13. Only then is a change made, and only to `.github/workflows/tests.yml` or the repo's PHPStan config file. The change goes in a separate PR against `main`, never onto Dependabot's branch (D-003). Merging that PR is the user's call: release this job as blocked with a resume note naming the fix PR, and on resume rebase PR #8 onto the merged `main`. Pass condition: the `tests.yml` run on PR #8's rebased head has every matrix job green, including `P8.5 / L13.* / prefer-stable / ubuntu-latest`, the PHPStan step log has no "Failed to open stream ... packages.php" line, and a single re-run on the same head is also fully green (D-004). If a push is refused (for example a token without the `workflow` scope, or a protected branch), release the job with that reason and do not retry blindly. +4. If the rebased run fails because composer cannot resolve paratest (identified by a composer "Your requirements could not be resolved" error naming paratest in the install step, as opposed to a prefer-lowest/prefer-stable difference), no fix is made here. Record it on #13, link the blocking campaign PR, and release the job as blocked (not done) with a resume note naming that PR (D-002). +5. If the rebased run fails for any other cause (a real setup-php 2.40.0 regression, or a different job failing), make no change: record the failing step and log excerpt on #13 and release the job as failed. +6. Checked per PR with `git diff --name-only` against `main`: PR #8 touches only `.github/workflows/tests.yml` (the setup-php bump). If criterion 3 applies, the separate fix PR touches only `.github/workflows/tests.yml` and/or the PHPStan config file. No file under `src/` changes in either. + +## Design + +No code design. The work is a rebase and a CI re-run; a workflow tweak (for example, warming the Testbench package cache before PHPStan) is a fallback only, per D-002. Order of fallbacks: rebase and re-run, then workflow/PHPStan config; paratest failures are out of this job. + +## Out of scope + +- Merging PR #8. +- Dropping Cortex's paratest conflict (separate campaign PR). +- Changes to Cortex source. +- `composer.json`, other workflows, matrix changes, and other Dependabot PRs. + +## Risks and open questions + +- The failure may be a flaky race, so green runs do not prove the cause; acceptance requires two consecutive green runs on the same head (D-004). +- A paratest resolution failure blocks this job until the campaign PR lands. +- A manual rebase pushed to PR #8's branch (D-005) stops Dependabot from rebasing or updating it, so the PR can go stale again. Pushing to `.github/workflows/*` also needs a token with the `workflow` scope, for the manual rebase and for the fix PR. +- If PR #8 is closed or superseded, note it on #13 and do no new work. + +## Addendum 2026-10-28 (D-003, D-004, D-005) + +These answers close the open questions above and override the criteria where they differ. + +- Green proof (D-004): criteria 2 and 3 pass only with two consecutive green `tests.yml` runs on the same head (re-run once after the first green run); both run URLs go on #13. +- Fix location (D-003): if the PHPStan bootstrap error still occurs, the workflow/PHPStan config fix goes in a separate PR against `main`, not onto Dependabot's branch. Once it is merged, PR #8 is rebased onto it and criterion 3's pass condition is checked on that head. Criterion 6 then applies to each PR separately: PR #8 stays the one-line setup-php bump, the fix PR touches only `.github/workflows/tests.yml` and/or the PHPStan config file. Merging the fix PR is the user's call. +- No Dependabot rebase (D-005): if `@dependabot rebase` is ignored, rebase PR #8's branch manually onto `main` and push to the PR branch, then continue with criterion 1's evidence. If the PR is closed or superseded, the Risks note above still applies. diff --git a/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/standards.md b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/standards.md new file mode 100644 index 0000000..2f76a7c --- /dev/null +++ b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/standards.md @@ -0,0 +1,7 @@ +# Standards for Fix CI failure on setup-php 2.40.0 bump + +No standard from `docs/agent/standards.index.yml` governs CI workflow files, and no Cortex source changes. The `package-compatibility` skill applies if the workflow matrix is touched. + +| Standard | File | Source | Why it applies | +| --- | --- | --- | --- | +| none | - | - | CI-only change | diff --git a/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/tasks.md b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/tasks.md new file mode 100644 index 0000000..922d6a1 --- /dev/null +++ b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/tasks.md @@ -0,0 +1,15 @@ +# Tasks: Fix CI failure on setup-php 2.40.0 bump + +## Group 1: Rebase PR #8 and prove CI green +depends on: none +files: .github/workflows/tests.yml (only if criterion 3 applies, in a separate PR against main; never on PR #8's branch) +criteria: 1, 2, 3, 4, 5, 6 + +- [x] 1.1 Write the checks first: record the `main` tip SHA, PR #8's current head SHA, and the failing job's log (`gh run view --log-failed`) on issue #13 as the baseline; define the pass check as `gh pr view 8 --json statusCheckRollup` showing every matrix job green and `git diff --name-only main...` listing only `.github/workflows/tests.yml` +- [x] 1.2 Check PR #8 is still open; if closed or superseded, note it on #13 and stop with no other change +- [x] 1.3 Comment `@dependabot rebase` on PR #8; if Dependabot ignores it, rebase the branch manually onto `main` and push it (D-005); a refused push releases the job with that reason +- [x] 1.4 Record on #13: new head SHA, merge-base equal to the `main` tip, and the run id of the `tests.yml` run on that head +- [x] 1.5 If every job is green, re-run the workflow once on the same head; if both runs are green, note both run URLs, per-job results and "race hypothesis unconfirmed" on #13, with no file changes (D-002, D-004) +- [x] 1.6 If the PHPStan "Failed to open stream ... packages.php" error recurs, reproduce with `composer analyse` or explain it from the log, record the cause on #13, open a separate fix PR against `main` touching only `.github/workflows/tests.yml` and/or the PHPStan config, then `release-task` as blocked with a resume note naming the fix PR (D-003); on resume, rebase PR #8 onto the merged `main` and repeat 1.4 and 1.5 (not needed: the error did not recur) +- [x] 1.7 If composer fails resolving paratest, record it on #13 with the blocking campaign PR link and `release-task` as blocked; for any other failure, record the failing step and log excerpt on #13 and `release-task` with `failed: true` (no change made) (not needed: both runs green) +- [x] 1.8 Verify criterion 6: `git diff --name-only main` per PR touches only the allowed files and nothing under `src/`; run `composer test` if any file changed (only `.github/workflows/tests.yml` on PR #8; no file changed, so no `composer test`) diff --git a/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/verification.md b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/verification.md new file mode 100644 index 0000000..bbb68e9 --- /dev/null +++ b/docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/verification.md @@ -0,0 +1,39 @@ +# Verification: Fix CI failure on setup-php 2.40.0 bump + +Date: 2026-10-28 · Result: FAIL (local gate only; every acceptance criterion passes, and the job changed no repo file) + +| Check | Result | Detail | +| --- | --- | --- | +| Criterion 1: PR #8 rebased onto `main`, `tests.yml` ran on the new head | pass | `@dependabot rebase` ignored; manual rebase per D-005. Head `2567b56` → `8a2bde7`, merge-base `c914866` (the `main` tip at push time), run 40637729378. Recorded on #13 (comment 6461508557) | +| Criterion 2: two consecutive green runs, no file changes, note on #13 | pass | Run 40637729378 attempts 1 and 2: all 4 jobs success, including `P8.5 - L13.* - prefer-stable - ubuntu-latest`; both URLs, per-job table and "race hypothesis unconfirmed" on #13 | +| Criterion 3: PHPStan bootstrap error handling | pass (not triggered) | No "Failed to open stream ... packages.php" line in attempt 1's log; no fix PR needed | +| Criterion 4: paratest resolution failure | pass (not triggered) | Original failure was the paratest conflict, fixed on `main` by #14; the rebased runs resolve | +| Criterion 5: other failure | pass (not triggered) | Both runs green | +| Criterion 6: PR #8 touches only `.github/workflows/tests.yml`, nothing under `src/` | pass | `git diff --name-only main...8a2bde7` → `.github/workflows/tests.yml` | +| Tasks | pass | Every box in `tasks.md` ticked | +| Full gate (`composer test`) | fail | 655/656 pass; 1 failure in `tests/Feature/Compat/KeenInCiTest.php`. Pre-existing: the working tree is `main` with no tracked changes. PHPStan and Pint pass | +| Standards drift (`vendor/bin/ringside check`) | fail | "Generated files are stale or missing. Run: vendor/bin/ringside sync". Pre-existing, unrelated to this job | + +## Failures + +`composer test`: + +``` +{"tool":"pest","result":"failed","tests":656,"passed":655,"failed":1, + "failures":[{"test":"...KeenInCiTest::it keeps refactor-circus/keen in require-dev with a lock entry", + "file":"tests/Feature/Compat/KeenInCiTest.php","line":93, + "message":"Failed asserting that an array contains 'refactor-circus/keen'."}]} +``` + +Cause: the test reads the root `composer.lock`, which is gitignored (`.gitignore:6`) and stale in this checkout. It has no `refactor-circus/keen` entry, although `vendor/refactor-circus/keen` is installed as a symlink by the local (`composer.local.json`) install. CI makes a fresh lock and passes this test on both runs. + +`vendor/bin/ringside check`: + +``` +ringside: 1 problem(s) + Generated files are stale or missing. Run: vendor/bin/ringside sync +``` + +## Tasks to reopen + +None. Neither failure comes from this job's work, which changed no repo file. They are local-environment problems on `main`. Whether that blocks `done` is questions.yml Q-001. diff --git a/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/decisions.md b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/decisions.md new file mode 100644 index 0000000..7d19bce --- /dev/null +++ b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/decisions.md @@ -0,0 +1,49 @@ +# Decisions + +## D-001: Ticket handling + +- **Question:** Ticket draft "Drop brianium/paratest conflict so composer resolves with Pest 5.3": create a new GitHub issue as drafted, or use existing issue #13? +- **Choice:** Use existing issue (#13, "Fix CI failure on setup-php 2.40.0 bump (PR #8)"). +- **Rationale:** None given. The recommendation was the existing issue, since #13 covers this CI failure. +- **Date:** 2026-10-28 +- **Raised by:** ticket (answered in RingMaster) + +## D-002: Standards for this change + +- **Question:** Which standards apply to this composer.json-only change (drop the brianium/paratest conflict)? +- **Choice:** architecture/dependencies only. +- **Rationale:** None given. Matches the recommendation: only composer.json constraints change, no code or tests. +- **Date:** 2026-10-28 +- **Raised by:** shape (answered in RingMaster) + +## D-003: Raising pest/phpunit constraints if dropping the conflict is not enough + +- **Question:** If dropping the conflict alone does not resolve, may the job raise the pestphp/pest or phpunit constraints in composer.json, or must it stop and report? +- **Choice:** Stop and report; do not change pest/phpunit constraints in this job. +- **Rationale:** None given. Matches the recommendation: criterion 6 and Out of scope keep the diff to removing the conflict. +- **Date:** 2026-10-28 +- **Raised by:** spec-review (answered in RingMaster) + +## D-004: Verifying "resolves on every CI lane" + +- **Question:** How is 'resolves on every CI lane' verified before merge? +- **Choice:** Require the P8.5 / L13.* CI checks on the PR to be green. +- **Rationale:** None given. Matches the recommendation: tests.yml has a prefer-lowest/prefer-stable matrix that local checks do not cover. +- **Date:** 2026-10-28 +- **Raised by:** spec-review (answered in RingMaster) + +## D-005: Spec approval + +- **Question:** Approve the spec as written (remove the brianium/paratest conflict; no pest/phpunit constraint changes; the PR's P8.5 / L13.* checks must be green)? +- **Choice:** Approve the spec. +- **Rationale:** None given. Matches the recommendation: D-003 and D-004 are reflected in spec.md. +- **Date:** 2026-10-28 +- **Raised by:** approval (answered in RingMaster) + +## D-006: Other packages still declare the paratest conflict + +- **Question:** Dropping Cortex's brianium/paratest conflict is not enough: Atrium, Keen and PennantPlus (installed as dev-main) still declare the same conflict. How should this job proceed? +- **Choice:** Hold this job; open follow-up jobs in Atrium, Keen and PennantPlus to drop their conflict, then resume. +- **Rationale:** None given. Matches the recommendation: composer cannot resolve until those packages drop the conflict, and changing them belongs in their own jobs. +- **Date:** 2026-10-28 +- **Raised by:** build (answered in RingMaster) diff --git a/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/meta.yml b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/meta.yml new file mode 100644 index 0000000..2f6c551 --- /dev/null +++ b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/meta.yml @@ -0,0 +1,10 @@ +id: 2026-10-27-2251-drop-paratest-conflict-for-pest-5-3 +title: Drop brianium/paratest conflict so composer resolves with Pest 5.3 +status: closed +review_passes: 2 +created: 2026-10-27 +ticket: { provider: github, key: "#13", url: https://github.com/Refactor-Circus/Cortex/issues/13 } +standards: + refactor-circus/standards: + version: dev-main + reference: a5b675396232 diff --git a/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/questions.yml b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/questions.yml new file mode 100644 index 0000000..fe51488 --- /dev/null +++ b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/questions.yml @@ -0,0 +1 @@ +[] diff --git a/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/references.md b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/references.md new file mode 100644 index 0000000..a5562cb --- /dev/null +++ b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/references.md @@ -0,0 +1,6 @@ +# References + +- **PR #7** (this repo): added the `brianium/paratest >=7.26.1` conflict. Relevance: the entry to remove. Pattern: check why it was added before dropping it. +- **Issue #13** (https://github.com/Refactor-Circus/Cortex/issues/13): the ticket; CI failure on the setup-php 2.40.0 bump (PR #8). +- **`composer.json`** lines 32, 88-91, 165-167: pest constraint, test scripts, the conflict entry. +- **`docs/agent/specs/2026-10-27-1055-fix-setup-php-2-40-0-bump/`**: sibling spec for the same CI failure; check overlap before building. diff --git a/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/shape.md b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/shape.md new file mode 100644 index 0000000..835552f --- /dev/null +++ b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/shape.md @@ -0,0 +1,25 @@ +# Drop brianium/paratest conflict so composer resolves with Pest 5.3 — Shaping Notes + +## Scope + +Change to `composer.json` (lock and CI config only if needed): `conflict` has `brianium/paratest: >=7.26.1` (added in PR #7). `pestphp/pest ^5.3.1` resolves to v5.3.2+, which needs paratest `^7.26.1`+, so the `P8.5 / L13.*` CI jobs cannot resolve. v5.3.1 conflicts with phpunit 13.4.5, so pinning to it is no way out. + +Outcome: verify paratest 7.27.x works locally (`composer test:unit`, `vendor/bin/pest --parallel`), remove the conflict entry (raise pest/phpunit constraints if needed), PR against main, `composer test` green. + +Out of scope: anything but `composer.json` (plus lock/CI config if needed). + +## Decisions + +- D-001: use existing issue #13 (https://github.com/Refactor-Circus/Cortex/issues/13) as the ticket instead of creating a new one. +- D-002: standards for this change are `architecture/dependencies` only. +- Note: #13 is titled "Fix CI failure on setup-php 2.40.0 bump (PR #8)" and asks for PR #8's checks to go green; this job removes the resolution failure behind that CI failure. + +## Context + +- `composer.json:165-167` holds the `conflict` entry; `composer.json:32` pins `pestphp/pest ^5.3.1`; the `test:unit` script runs `vendor/bin/pest --parallel`. +- Sibling specs in `docs/agent/specs/` (setup-php 2.40.0 bump) are about the same CI failure. +- No product docs alignment needed. + +## Standards + +- `architecture/dependencies` (confirmed, D-002): constraints in composer.json; the change adds no dependency, it only drops a conflict entry. diff --git a/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/spec-review.md b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/spec-review.md new file mode 100644 index 0000000..3589489 --- /dev/null +++ b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/spec-review.md @@ -0,0 +1,15 @@ +# Spec review + +## Round 1 + +Changes made to spec.md. The two open questions (may the fallback raise pest/phpunit constraints; how "resolves on every CI lane" is verified before merge) were left open and not decided. + +- Goal: named the lanes from `.github/workflows/tests.yml` (PHP 8.5, Laravel 13.*, prefer-lowest and prefer-stable) and said what is locally verifiable versus confirmed on the PR. Why: the goal was unverifiable by the old criteria. +- Criterion 3 (new): resolution must succeed under both `prefer-lowest` and `prefer-stable`, run as the workflow runs them, optionally in a scratch copy; prefer-lowest must not land on Pest 5.3.1. Why: the workflow runs both, and 5.3.1 is the known-bad floor. How the check is run in practice is left to the verifier, so the "how verified" question stays open. +- Criteria 4 and 5: pass condition stated as exit code 0; added rerun and non-parallel comparison to tell a paratest regression from a real failure, and a double `--parallel` run for flakiness. +- Criterion 6: diff check stated as a `git diff --name-only` subset. Finding said `composer.lock` is tracked, but `.gitignore` line 6 ignores it, so the spec now says it is never in the diff. +- Criterion 7 (new): the PR's `P8.5 / L13.*` CI checks are green; PR #8 may still need a rebase or re-run. +- Criterion 8: PR body must contain `Refs #13`, not `Closes`, because this PR only unblocks PR #8. +- Design: prefer `composer update pestphp/pest brianium/paratest --with-dependencies` over a full update; fallback bounded to the minimum pest/phpunit versions verified with `composer why-not`, and stop and report if another package's constraint must change. Whether the fallback is allowed at all remains the open question. Added a note that consumers are unaffected. +- Risks: implementer must read PR #7 and its commit message, record the reason in the PR description, and check the symptom does not reappear. +- Out of scope: stated that the PR does not close #13; removed the mention of lock changes. diff --git a/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/spec.md b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/spec.md new file mode 100644 index 0000000..a8e9c20 --- /dev/null +++ b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/spec.md @@ -0,0 +1,40 @@ +# Drop brianium/paratest conflict so composer resolves with Pest 5.3 + +Ticket: [#13](https://github.com/Refactor-Circus/Cortex/issues/13) + +## Goal +Make `composer update` resolve on every CI lane by removing the `brianium/paratest` conflict that blocks `pestphp/pest ^5.3.1` (v5.3.2+ needs paratest `^7.26.1`). The lanes are the `tests.yml` matrix: PHP 8.5, Laravel 13.*, stability `prefer-lowest` and `prefer-stable`, on each OS in the matrix. This unblocks the red checks behind the setup-php 2.40.0 bump (PR #8). + +Locally verifiable: resolution under both stabilities and the test suite. CI is the final confirmation on this PR's own checks (criterion 7). + +## Acceptance criteria +1. `composer.json` has no `brianium/paratest` entry under `conflict`; if that leaves `conflict` empty, the key is removed. +2. `composer update` resolves without error on the local PHP version, installing `pestphp/pest` 5.3.2 or later and `brianium/paratest` 7.26.1 or later. +3. Resolution also succeeds under both CI stabilities, run the way the workflow runs them (`composer require "laravel/framework:13.*" "orchestra/testbench:" --no-update`, then `composer update --prefer-lowest ...` and `composer update --prefer-stable ...`). The verifier may use a scratch copy of the repo so the working tree and `vendor/` stay untouched. Under `prefer-lowest`, the resolved `pestphp/pest` must not be 5.3.1 (known to conflict with phpunit 13.4.5); if it is, stop and report (D-003); the floors in `composer.json` are not changed in this job. +4. `composer test` exits 0. +5. `vendor/bin/pest --parallel` (the `test:unit` script) exits 0 with the resolved paratest. If it fails, rerun once and compare with `vendor/bin/pest` (non-parallel): a failure that also happens non-parallel is a real failure, a failure only under `--parallel` that repeats is a paratest regression and triggers the stop-and-report path in Risks. Run `--parallel` at least twice to catch flakiness. +6. `git diff --name-only` is a subset of {`composer.json`, `.github/workflows/*`}. `composer.lock` is gitignored in this repo, so it is never part of the diff. +7. The PR's CI checks (every `P8.5 / L13.*` job) are green. PR #8 may still need a rebase or re-run once this merges; that is outside this PR. +8. The PR targets `main`, and its body contains `Refs #13` (not `Closes`): this PR unblocks PR #8's checks, and #13 is closed when PR #8's checks go green. + +## Design +Delete the `"conflict": { "brianium/paratest": ">=7.26.1" }` block from `composer.json`. Add no new dependency (`architecture/dependencies`). + +To keep the change narrow, resolve locally with `composer update pestphp/pest brianium/paratest --with-dependencies` rather than a full `composer update`, so unrelated dev dependencies do not move. + +No fallback (D-003): if resolution still fails (including the `prefer-lowest` case in criterion 3), stop and report with the `composer why-not` output. Do not change the `pestphp/pest`, `phpunit/phpunit` or any other constraint in this job. + +Consumers: `conflict` in a package's `composer.json` is inherited by apps that require it. Dropping the entry only loosens their constraints, so consumers are unaffected; say so in the PR description. + +## Out of scope +- Changes to anything but `composer.json` (plus CI config if needed). +- The setup-php 2.40.0 bump itself (its own spec). This PR does not close #13; it only unblocks PR #8's checks. +- Pinning Pest to 5.3.1, which conflicts with phpunit 13.4.5. + +## Risks and open questions +- Paratest 7.26.1+ may behave differently under `--parallel`; criterion 5 covers it. +- The conflict was added in PR #7 for a reason not recorded here. Before removing the entry, the implementer reads PR #7 and its commit message and records the reason in the PR description, then checks that the symptom does not reappear (criteria 4 and 5). If the suite fails under the newer paratest, the job must stop and report rather than re-add the conflict. + +## Addendum 2026-10-28 (D-003, D-004) +- D-003: the Design fallback is not permitted. If dropping the conflict alone does not resolve (including criterion 3's `prefer-lowest` case), the job stops and reports; it never changes the `pestphp/pest` or `phpunit/phpunit` constraints. Design and criterion 3 now say so. +- D-004: "resolves on every CI lane" is verified by the PR's `P8.5 / L13.*` checks being green (criterion 7); local resolution alone is not enough to merge. diff --git a/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/standards.md b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/standards.md new file mode 100644 index 0000000..e95971e --- /dev/null +++ b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/standards.md @@ -0,0 +1,5 @@ +# Standards for Drop brianium/paratest conflict so composer resolves with Pest 5.3 + +| Standard | File | Source | Why it applies | +| --- | --- | --- | --- | +| architecture/dependencies | vendor/refactor-circus/standards/standards/architecture/dependencies.md | refactor-circus/standards@dev-main | The change edits composer.json constraints (removes a `conflict` entry). It adds no dependency. | diff --git a/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/tasks.md b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/tasks.md new file mode 100644 index 0000000..9b97a8a --- /dev/null +++ b/docs/agent/specs/2026-10-27-2251-drop-paratest-conflict-for-pest-5-3/tasks.md @@ -0,0 +1,16 @@ +# Tasks: Drop brianium/paratest conflict so composer resolves with Pest 5.3 + +## Group 1: Remove the paratest conflict and verify resolution +depends on: none +files: composer.json +criteria: 1, 2, 3, 4, 5, 6, 7, 8 + +- [ ] 1.1 Read PR #7 and its commit message for why the `brianium/paratest` conflict was added; note the reason for the PR description (Refs #13, not Closes; consumers only get looser constraints) +- [ ] 1.2 Record the failing baseline: `composer update` resolution fails while the conflict is present (criterion 2 check, before the change) +- [ ] 1.3 Delete the `brianium/paratest` entry from `conflict` in `composer.json`; remove the `conflict` key if it ends up empty (criterion 1) +- [ ] 1.4 Run `composer update pestphp/pest brianium/paratest --with-dependencies`; confirm pest >= 5.3.2 and paratest >= 7.26.1 are installed (criterion 2) +- [ ] 1.5 In a scratch copy of the repo, run the workflow's `composer require "laravel/framework:13.*" "orchestra/testbench:" --no-update`, then `composer update --prefer-lowest` and `composer update --prefer-stable`; under prefer-lowest pest must not be 5.3.1, otherwise stop and report with `composer why-not` output (D-003; do not change pest/phpunit constraints) (criterion 3) +- [ ] 1.6 Run `composer test`; all green (criterion 4) +- [ ] 1.7 Run `vendor/bin/pest --parallel` at least twice; on a failure rerun once and compare with `vendor/bin/pest`; a repeated parallel-only failure means stop and report, never re-add the conflict (criterion 5) +- [ ] 1.8 Check `git diff --name-only` is a subset of `composer.json` and `.github/workflows/*` (criterion 6) +- [ ] 1.9 Open the PR against `main` with `Refs #13`; the `P8.5 / L13.*` checks must be green before merge (criteria 7, 8) diff --git a/docs/agent/specs/2026-10-28-0100-drop-paratest-conflict-pin/meta.yml b/docs/agent/specs/2026-10-28-0100-drop-paratest-conflict-pin/meta.yml new file mode 100644 index 0000000..22664e5 --- /dev/null +++ b/docs/agent/specs/2026-10-28-0100-drop-paratest-conflict-pin/meta.yml @@ -0,0 +1,6 @@ +id: 2026-10-28-0100-drop-paratest-conflict-pin +title: Drop the paratest conflict pin and require pest ^5.3.4 +status: merged +created: 2026-10-28 +ticket: { provider: github, key: "#13", url: "https://github.com/Refactor-Circus/Cortex/issues/13" } +pr: { number: 14, url: "https://github.com/Refactor-Circus/Cortex/pull/14" } diff --git a/docs/agent/specs/2026-10-28-0100-drop-paratest-conflict-pin/spec.md b/docs/agent/specs/2026-10-28-0100-drop-paratest-conflict-pin/spec.md new file mode 100644 index 0000000..e3d7be9 --- /dev/null +++ b/docs/agent/specs/2026-10-28-0100-drop-paratest-conflict-pin/spec.md @@ -0,0 +1,10 @@ +# Drop the paratest conflict pin and require pest ^5.3.4 + +Campaign "Drop the paratest conflict pin" (RingMaster campaign 1), task #20. + +Cortex and PennantPlus each require the other's dev-main, so the two pin-drops were made together by hand (PennantPlus PR #7) instead of through the factory, and checked against each other: pest 5.3.4 with paratest 7.27.4, `vendor/bin/pest --parallel` passes (656 tests). + +## Acceptance criteria + +1. composer.json has no `conflict` on brianium/paratest and requires pestphp/pest ^5.3.4. +2. CI is green once PennantPlus PR #7 is merged too.