From 88e83b3e1184589c0c6d964399a600ee547921f8 Mon Sep 17 00:00:00 2001 From: Yaacov Date: Tue, 17 Nov 2026 02:52:00 +0200 Subject: [PATCH 1/4] docs(scient): definition of done and review line in the PR template Co-Authored-By: Claude Opus 5.5 --- .github/PULL_REQUEST_TEMPLATE.md | 15 +++++++++++++++ AGENTS.md | 2 +- SCIENT.md | 9 +++++++++ scripts/scient/divergences.json | 2 +- 4 files changed, 26 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 265cdab79d..c6be94164f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -12,6 +12,21 @@ + +## Platforms + + + +## Review + + + +Review: + +- [ ] Every link or URL this PR adds was fetched and works + + --- - [ ] `bun check` passes diff --git a/AGENTS.md b/AGENTS.md index c92b0d029f..dd1103d978 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -1,7 +1,7 @@ # Development Rules -> **This is Scient Agent, Scient's fork of Oh My Pi.** Before changing anything, read [SCIENT.md](SCIENT.md), above all "Keeping Scient's changes apart": every change goes where the next alignment with Oh My Pi costs least, and Scient's rules there come before this file's. +> **This is Scient Agent, Scient's fork of Oh My Pi.** Before changing anything, read [SCIENT.md](SCIENT.md), above all "Keeping Scient's changes apart": every change goes where the next alignment with Oh My Pi costs least, and Scient's rules there come before this file's. Work is done only when it meets SCIENT.md's "Definition of done". ## Default Context diff --git a/SCIENT.md b/SCIENT.md index eddf874f6f..e91b8c60e4 100644 --- a/SCIENT.md +++ b/SCIENT.md @@ -1060,6 +1060,15 @@ Scient's own tests live in `test/scient/` folders and run on macOS with the plat The macOS native test process preloads `scripts/scient/macos-spelling-ready.ts`. AppKit can return no spans when its first XPC request times out during spelling-service startup; the preflight requires the service to identify a known misspelling within three probes before running the unchanged tests. Persistent unavailability fails qualification. This provisions the CI fixture; it does not retry failed tests, change runtime results, or qualify cold-service startup behavior. +## Definition of done + +Report work as done only when all of these hold on the final head: + +- `bun check` and the focused tests of the changed area pass, and so do the checks above that the change touches: `divergence-check.ts` for any change to an Oh My Pi file, and the generators' `--check` for names and wording. +- Every link or URL the change adds was fetched once and works. +- The pull request says, for macOS, Linux and Windows, what ran there and what is still unproven. The six-platform CI proves the build and the isolation check on each system, not behavior that differs between them. +- The pull request is open and names its review. This repository has no merge queue, required checks or auto-merge: merge only when authorized, on the reviewed head, after its CI is green (`gh pr merge --rebase --match-head-commit `). + ## Release `.github/workflows/scient.yml` builds and checks every platform on every push to `main` and on every pull request into it: macOS (Apple silicon and Intel), Linux (x86-64 and ARM64, glibc) and Windows (x86-64 and ARM64), each on its own GitHub-hosted runner, each with the isolation check. The first step stamps the commit into `packages/coding-agent/src/scient/build-id.ts` (`scripts/scient/stamp-build-id.ts`), which `--runtime-info` reports; a build made elsewhere reports `source`. On x86-64 the binary carries the `modern` (AVX2) and `baseline` native addons (`PI_NATIVE_X64_VARIANT` builds each). Before an addon is cached and embedded, `scripts/scient/strip-native.ts` strips the symbol tables and debug information the `local` cargo profile leaves, as Oh My Pi strips its release addons: Apple's `strip -x -S` on macOS, which keeps the arm64 linker signature valid, and `strip --strip-unneeded` on Linux. Windows keeps that information in separate `.pdb` files, so its addons are left as built. diff --git a/scripts/scient/divergences.json b/scripts/scient/divergences.json index 699bebf83c..0758e3bb84 100644 --- a/scripts/scient/divergences.json +++ b/scripts/scient/divergences.json @@ -226,7 +226,7 @@ }, "SA-POLICY": { "status": "active", - "contract": "An agent working here reads SCIENT.md first, and its rule on keeping Scient's changes apart comes before Oh My Pi's guidance; Scient accepts AI-assisted pull request descriptions, and the contributor stays responsible for them.", + "contract": "An agent working here reads SCIENT.md first, and its rule on keeping Scient's changes apart comes before Oh My Pi's guidance; Scient accepts AI-assisted pull request descriptions, and the contributor stays responsible for them. Its pull requests meet SCIENT.md's definition of done.", "upstream": [".github/PULL_REQUEST_TEMPLATE.md", "AGENTS.md", "CONTRIBUTING.md"] }, "SA-SECURITY": { From 1f551ec5ff20fe661acfe3dd767a061e48e69de7 Mon Sep 17 00:00:00 2001 From: Yaacov Date: Tue, 17 Nov 2026 03:01:49 +0200 Subject: [PATCH 2/4] docs(scient): apply review fixes to the definition of done Co-Authored-By: Claude Opus 5.5 --- .github/PULL_REQUEST_TEMPLATE.md | 7 +------ SCIENT.md | 6 ++++-- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index c6be94164f..ea3fc479ec 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -19,12 +19,7 @@ ## Review - - -Review: - -- [ ] Every link or URL this PR adds was fetched and works + --- diff --git a/SCIENT.md b/SCIENT.md index e91b8c60e4..df0cc92d00 100644 --- a/SCIENT.md +++ b/SCIENT.md @@ -1065,9 +1065,11 @@ The macOS native test process preloads `scripts/scient/macos-spelling-ready.ts`. Report work as done only when all of these hold on the final head: - `bun check` and the focused tests of the changed area pass, and so do the checks above that the change touches: `divergence-check.ts` for any change to an Oh My Pi file, and the generators' `--check` for names and wording. -- Every link or URL the change adds was fetched once and works. +- A change to a page or screen the agent shows (sign-in pages, the stats dashboard, the terminal) has before/after screenshots in the pull request, light and dark where the screen has both, checked against Scient Desktop's [UI checklist](https://github.com/ScientFactory/scient-desktop/blob/main/docs/internals/web-ui.md#ui-checklist). +- Every link a reader can follow that the change adds (docs, messages, pull request text) was fetched once and works. - The pull request says, for macOS, Linux and Windows, what ran there and what is still unproven. The six-platform CI proves the build and the isolation check on each system, not behavior that differs between them. -- The pull request is open and names its review. This repository has no merge queue, required checks or auto-merge: merge only when authorized, on the reviewed head, after its CI is green (`gh pr merge --rebase --match-head-commit `). +- The pull request names its review and result in the template's Review section. +- The delivery the task allowed is complete. Without pull request authorization, the handback names the branch, head and what is still owed. Merge only when authorized, on the head that had its review, after `gh pr checks ` shows every job green (`gh pr merge --rebase --match-head-commit `). Rerun a failed job the change cannot have caused once; if it fails again, report it instead of merging. ## Release From fa22b74ddf621a424585698275e76c147021c745 Mon Sep 17 00:00:00 2001 From: Yaacov Date: Tue, 17 Nov 2026 03:11:18 +0200 Subject: [PATCH 3/4] docs(scient): apply recheck fixes to the definition of done Co-Authored-By: Claude Opus 5.5 --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- SCIENT.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ea3fc479ec..6083a343de 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -19,7 +19,7 @@ ## Review - + --- diff --git a/SCIENT.md b/SCIENT.md index df0cc92d00..fa1a68ab77 100644 --- a/SCIENT.md +++ b/SCIENT.md @@ -1062,10 +1062,10 @@ The macOS native test process preloads `scripts/scient/macos-spelling-ready.ts`. ## Definition of done -Report work as done only when all of these hold on the final head: +Report work as done only when all of these hold on the final head. Without a pull request, the handback carries what the pull request would. - `bun check` and the focused tests of the changed area pass, and so do the checks above that the change touches: `divergence-check.ts` for any change to an Oh My Pi file, and the generators' `--check` for names and wording. -- A change to a page or screen the agent shows (sign-in pages, the stats dashboard, the terminal) has before/after screenshots in the pull request, light and dark where the screen has both, checked against Scient Desktop's [UI checklist](https://github.com/ScientFactory/scient-desktop/blob/main/docs/internals/web-ui.md#ui-checklist). +- A change to a page or screen the agent shows (sign-in pages, the stats dashboard, the terminal) has before/after screenshots in the pull request, light and dark where the screen has both, checked against Scient Desktop's [UI checklist](https://github.com/ScientFactory/scient-desktop/blob/main/docs/internals/web-ui.md#ui-checklist) and attached as its "Screenshots in a PR" describes. - Every link a reader can follow that the change adds (docs, messages, pull request text) was fetched once and works. - The pull request says, for macOS, Linux and Windows, what ran there and what is still unproven. The six-platform CI proves the build and the isolation check on each system, not behavior that differs between them. - The pull request names its review and result in the template's Review section. From 2d881f394afceb7069b5f7d95a0ce1a9bd107b66 Mon Sep 17 00:00:00 2001 From: Yaacov Date: Tue, 17 Nov 2026 13:52:59 +0200 Subject: [PATCH 4/4] docs(scient): name the required CI passed check in the definition of done Co-Authored-By: Claude Opus 5.5 --- SCIENT.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SCIENT.md b/SCIENT.md index fa1a68ab77..c4e799d480 100644 --- a/SCIENT.md +++ b/SCIENT.md @@ -1069,7 +1069,7 @@ Report work as done only when all of these hold on the final head. Without a pul - Every link a reader can follow that the change adds (docs, messages, pull request text) was fetched once and works. - The pull request says, for macOS, Linux and Windows, what ran there and what is still unproven. The six-platform CI proves the build and the isolation check on each system, not behavior that differs between them. - The pull request names its review and result in the template's Review section. -- The delivery the task allowed is complete. Without pull request authorization, the handback names the branch, head and what is still owed. Merge only when authorized, on the head that had its review, after `gh pr checks ` shows every job green (`gh pr merge --rebase --match-head-commit `). Rerun a failed job the change cannot have caused once; if it fails again, report it instead of merging. +- The delivery the task allowed is complete. Without pull request authorization, the handback names the branch, head and what is still owed. Merge only when authorized, on the head that had its review, after `gh pr checks ` shows every job green, `CI passed` included, which `main` requires (`gh pr merge --rebase --match-head-commit `). Rerun a failed job the change cannot have caused once; if it fails again, report it instead of merging. ## Release