Skip to content

The new Phase 3 test-count rule refers to {{TEST_CMD}} as a substitution, so generated skills read as nonsense #126

Description

@dmccoystephenson

Summary

The Phase 3 rule added by #121 ends with a sentence that does not survive substitution:

Where zero tests ran, the green verifies nothing and must never be reported as "tests pass" — say so plainly and fall back to whatever the {{TEST_CMD}} substitution names as the real gate for this repo.

{{TEST_CMD}} is replaced with the command itself, so a generated instance reads:

... fall back to whatever the ./gradlew test substitution names as the real gate for this repo.

The sentence describes the substitution mechanism from the template's point of view, which is exactly the context a generated child skill does not have.

Suggested wording

... — say so plainly, and treat {{TEST_CMD}} as this repo's real gate rather than the count-free banner.

That reads correctly both in the template and after substitution. It is the phrasing the pass-2 retrofit used when propagating this rule to the instance skills, so adopting it upstream also removes a divergence between the template and its children.

Related

The same class of defect is worth a scan of the whole template: any sentence that refers to a {{TOKEN}} as a token rather than using it as a value will be nonsense in every generated skill.

Found while propagating #121 to the instance skills.


drafted by Claude on behalf of Daniel Stephenson

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions