LilyGO T-Deck Max: enable the SD card

[Crazypedia]

The sdcard@1 node is already present and correct in the board devicetree, just held at status = "disabled". Enabling it is a one-line change.

 sdcard@1 {
     compatible = "espressif,esp32-sdspi";
-    status = "disabled";
     frequency-khz = <20000>;
 };

Verified on hardware: a 16 GB FAT32 card mounts at boot and the Files app can browse it and write to it. It shares SPI2 with the e-paper panel and the LoRa radio, and I have seen no contention in normal use.

[KenVanHoeylandt]

Considering that you verified it, feel free to open a PR for it!

Some background:

"disabled" SD cards get auto-enabled in the Boot app (the splash screen). Or at least they should be 😅
Some devices have this set like that because enabling it earlier fails to mount the SD card.

[Crazypedia]

You were right, and I should not have filed this. Closing as unnecessary.

I tested it properly: restored status = "disabled" on the node, flashed, and the card mounts anyway.

I (14393) device: start sdcard
I (14394) esp32_sdspi_fs: Mounting /sdcard
I (14488) esp32_sdspi_fs: Mounted /sdcard

hal::sdcard::startAll() in Tactility.cpp starts every SDCARD_TYPE device regardless of DTS status, so the only difference is timing: t=14393 deferred versus t=12013 when enabled in the devicetree. No errors either way, and the Files app is happy. So the auto-enable is working, and given that some boards fail to mount when started earlier, the deferred path is the one this board should be using too.

One thing I noticed while checking, and I am not sure whether it is worth a separate issue. The start failure is swallowed:

device_for_each_of_type(&SDCARD_TYPE, nullptr, [](::Device* device, void*) -> bool {
    if (!device_is_ready(device)) {
        if (device_start(device) != ERROR_NONE) {
        }
    }
    return true;
});

The empty branch means a card that fails to start produces no log line at all, which would make "the SD card does not work" quite hard to diagnose on a board where it genuinely fails. Happy to send a one-line LOG_W if you want it, or to leave it alone if the silence is deliberate.

[KenVanHoeylandt]

Verified on hardware: a 16 GB FAT32 card mounts at boot and the Files app can browse it and write to it. It shares SPI2 with the e-paper panel and the LoRa radio, and I have seen no contention in normal use.

It's preferrable to have the SD card enabled by default if it succeeds that way.