From bb57a9df88d8faae4f0f4eda062a0e1815da29a3 Mon Sep 17 00:00:00 2001 From: deepshekhardas Date: Mon, 17 Aug 2026 10:22:11 +0530 Subject: [PATCH] fix: make bad character shift effective in boyer_moore_search The for-loop variable reassignment had no effect; use a while loop so the bad-character rule actually skips positions (O(n/m) not O(nm)). Fixes #14844 --- strings/boyer_moore_search.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/strings/boyer_moore_search.py b/strings/boyer_moore_search.py index ad14a504f792..cea4dbc2a7e0 100644 --- a/strings/boyer_moore_search.py +++ b/strings/boyer_moore_search.py @@ -86,15 +86,15 @@ def bad_character_heuristic(self) -> list[int]: """ positions = [] - for i in range(self.textLen - self.patLen + 1): + i = 0 + while i <= self.textLen - self.patLen: mismatch_index = self.mismatch_in_text(i) if mismatch_index == -1: positions.append(i) + i += 1 else: match_index = self.match_in_pattern(self.text[mismatch_index]) - i = ( - mismatch_index - match_index - ) # shifting index lgtm [py/multiple-definition] + i = max(i + 1, mismatch_index - match_index) return positions