From c40c46fa011460124398e18197705ca4f9aeb53a Mon Sep 17 00:00:00 2001 From: AnkitSingh411 Date: Sat, 7 Nov 2026 21:33:32 +0530 Subject: [PATCH] fix(sdk): treat depositId 0 as a valid deposit id MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit depositId is a bigint/number, so 0/0n is falsy. The truthiness guards in getDeposit, waitForDepositTx, waitForAtomicTx and parseFillLogs treated depositId 0 as missing: getDeposit threw before issuing any getLogs call and the waiters threw NoDepositLogError. Deposit ID 0 is legitimate — SpokePool starts numberOfDeposits at 0 — so the first deposit on any SpokePool could not be awaited or looked up by id. Compare against undefined instead of relying on truthiness. --- .changeset/fix-deposit-id-zero.md | 5 +++++ packages/sdk/src/actions/getDeposit.ts | 4 ++-- packages/sdk/src/actions/waitForAtomicTx.ts | 2 +- packages/sdk/src/actions/waitForDepositTx.ts | 2 +- packages/sdk/src/actions/waitForFillTx.ts | 2 +- 5 files changed, 10 insertions(+), 5 deletions(-) create mode 100644 .changeset/fix-deposit-id-zero.md diff --git a/.changeset/fix-deposit-id-zero.md b/.changeset/fix-deposit-id-zero.md new file mode 100644 index 0000000..b144e14 --- /dev/null +++ b/.changeset/fix-deposit-id-zero.md @@ -0,0 +1,5 @@ +--- +"@across-protocol/app-sdk": patch +--- + +Fix depositId 0 being treated as absent in getDeposit, waitForDepositTx, waitForAtomicTx and parseFillLogs diff --git a/packages/sdk/src/actions/getDeposit.ts b/packages/sdk/src/actions/getDeposit.ts index 2fc3b8d..7814739 100644 --- a/packages/sdk/src/actions/getDeposit.ts +++ b/packages/sdk/src/actions/getDeposit.ts @@ -47,7 +47,7 @@ export async function getDeposit( if ( !( findBy.depositTxHash || - (findBy.depositId && findBy.originSpokePoolAddress) + (findBy.depositId !== undefined && findBy.originSpokePoolAddress) ) ) { throw new Error( @@ -75,7 +75,7 @@ export async function getDeposit( } // Try to get deposit from logs by deposit id and spoke pool address on origin chain - else if (findBy.depositId && findBy.originSpokePoolAddress) { + else if (findBy.depositId !== undefined && findBy.originSpokePoolAddress) { const { depositId, originSpokePoolAddress } = findBy; const _depositId = BigInt(findBy.depositId); diff --git a/packages/sdk/src/actions/waitForAtomicTx.ts b/packages/sdk/src/actions/waitForAtomicTx.ts index b3112f5..7f55c32 100644 --- a/packages/sdk/src/actions/waitForAtomicTx.ts +++ b/packages/sdk/src/actions/waitForAtomicTx.ts @@ -38,7 +38,7 @@ export async function waitForAtomicTx( receipt, }); - if (!depositLog || !depositLog.depositId) { + if (!depositLog || depositLog.depositId === undefined) { throw new NoDepositLogError(callId as Hash, originChainId); } diff --git a/packages/sdk/src/actions/waitForDepositTx.ts b/packages/sdk/src/actions/waitForDepositTx.ts index ca7ba48..afd1efd 100644 --- a/packages/sdk/src/actions/waitForDepositTx.ts +++ b/packages/sdk/src/actions/waitForDepositTx.ts @@ -20,7 +20,7 @@ export async function waitForDepositTx( const depositLog = getDepositFromLogs({ originChainId, receipt }); - if (!depositLog || !depositLog.depositId) { + if (!depositLog || depositLog.depositId === undefined) { throw new NoDepositLogError(receipt.transactionHash, publicClient.chain.id); } diff --git a/packages/sdk/src/actions/waitForFillTx.ts b/packages/sdk/src/actions/waitForFillTx.ts index 200b24c..a353436 100644 --- a/packages/sdk/src/actions/waitForFillTx.ts +++ b/packages/sdk/src/actions/waitForFillTx.ts @@ -173,7 +173,7 @@ export function parseFillLogs( logs, args: { ...filter, - depositId: filter?.depositId ? BigInt(filter?.depositId) : undefined, + depositId: filter?.depositId !== undefined ? BigInt(filter.depositId) : undefined, }, }); const v3_5Log = parsedV3_5Logs?.[0];