From 8f5ec0eddbe7449d84e73be466339002839890e7 Mon Sep 17 00:00:00 2001 From: AnkitSingh411 Date: Sat, 7 Nov 2026 21:33:48 +0530 Subject: [PATCH] fix(sdk): honour update() returning value 0 in getQuote MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit getQuote applied an action's update() result with a truthiness check ('if (updated?.value)' / 'if (maybePromise?.value)'), so an update() that legitimately computed value 0 was ignored and the stale pre-quote value was encoded into the MulticallHandler message. 0n is a valid value — compare against undefined instead, in both the async and sync branches. --- .changeset/fix-getquote-value-zero.md | 5 +++++ packages/sdk/src/actions/getQuote.ts | 8 ++++---- 2 files changed, 9 insertions(+), 4 deletions(-) create mode 100644 .changeset/fix-getquote-value-zero.md diff --git a/.changeset/fix-getquote-value-zero.md b/.changeset/fix-getquote-value-zero.md new file mode 100644 index 0000000..3d9b430 --- /dev/null +++ b/.changeset/fix-getquote-value-zero.md @@ -0,0 +1,5 @@ +--- +"@across-protocol/app-sdk": patch +--- + +Fix getQuote ignoring update() returning value 0 and encoding a stale ETH value instead diff --git a/packages/sdk/src/actions/getQuote.ts b/packages/sdk/src/actions/getQuote.ts index 9c7eef6..382b177 100644 --- a/packages/sdk/src/actions/getQuote.ts +++ b/packages/sdk/src/actions/getQuote.ts @@ -176,15 +176,15 @@ export async function getQuote(params: GetQuoteParams): Promise { if (updated?.callData) { _callData = updated.callData; } - if (updated?.value) { - _value = updated?.value; + if (updated?.value !== undefined) { + _value = updated.value; } } else { if (maybePromise?.callData) { _callData = maybePromise.callData; } - if (maybePromise?.value) { - _value = maybePromise?.value; + if (maybePromise?.value !== undefined) { + _value = maybePromise.value; } } }