From d9dd23dc5cbdbc4add0bace025eba3da65501323 Mon Sep 17 00:00:00 2001 From: Sean Steimer Date: Tue, 15 Sep 2026 11:36:24 -0700 Subject: [PATCH 1/2] feat(shareddoc): bump da-parser to 2.2.0 for link-img support MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit No source changes needed — doc2aem/aem2doc come entirely from @adobe/da-parser. Adds a round-trip test covering the new link-img image delivery type. Co-Authored-By: Claude Sonnet 5 --- package.json | 2 +- test/shareddoc.test.js | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 42a710f..53e7fda 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,7 @@ "wrangler": "4.119.0" }, "dependencies": { - "@adobe/da-parser": "^2.1.0", + "@adobe/da-parser": "^2.2.0", "@cloudflare/workers-types": "5.20260804.1", "lib0": "0.2.117", "y-protocols": "1.0.7", diff --git a/test/shareddoc.test.js b/test/shareddoc.test.js index 2e21cd0..3c5b30c 100644 --- a/test/shareddoc.test.js +++ b/test/shareddoc.test.js @@ -3302,4 +3302,22 @@ describe('Collab Test Suite', () => { persistence.update = savedUpdate; } }); + + it('Test link-img image round-trips through doc2aem/aem2doc', async () => { + const html = ` + +
+
http://www.foo.com/myimg.jpg
+
+ +`; + + const ydoc = new Y.Doc(); + aem2doc(html, ydoc); + + const result = doc2aem(ydoc); + assert.equal(result, html); + assert(!result.includes(''), 'link-img must serialize as a plain , not '); + assert(result.includes('data-asset-delivery-type="link-img"')); + }); }); From 9abb77980ee1bd5a28b9e43fb335b1cddffa1938 Mon Sep 17 00:00:00 2001 From: Sean Steimer Date: Tue, 15 Sep 2026 12:01:00 -0700 Subject: [PATCH 2/2] refactor(shareddoc): revert da-parser bump, rename link-img marker Revert @adobe/da-parser to ^2.1.0 -- no real published version exists yet for the link-img support (adobe/da-tools#27), and da-parser doesn't hand-bump its own version (semantic-release does that on merge). Bumping to ^2.2.0 is a required step before merging this PR, once that version is published. Update the round-trip test for da-parser's renamed marker: data-asset-delivery-type="link-img" -> data-edit-as="image". Verified passing against the (locally npm-linked) updated parser. Co-Authored-By: Claude Sonnet 5 --- package.json | 2 +- test/shareddoc.test.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 53e7fda..42a710f 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,7 @@ "wrangler": "4.119.0" }, "dependencies": { - "@adobe/da-parser": "^2.2.0", + "@adobe/da-parser": "^2.1.0", "@cloudflare/workers-types": "5.20260804.1", "lib0": "0.2.117", "y-protocols": "1.0.7", diff --git a/test/shareddoc.test.js b/test/shareddoc.test.js index 3c5b30c..8411806 100644 --- a/test/shareddoc.test.js +++ b/test/shareddoc.test.js @@ -3307,7 +3307,7 @@ describe('Collab Test Suite', () => { const html = `
-
http://www.foo.com/myimg.jpg
+
http://www.foo.com/myimg.jpg
`; @@ -3318,6 +3318,6 @@ describe('Collab Test Suite', () => { const result = doc2aem(ydoc); assert.equal(result, html); assert(!result.includes(''), 'link-img must serialize as a plain , not '); - assert(result.includes('data-asset-delivery-type="link-img"')); + assert(result.includes('data-edit-as="image"')); }); });