Repository navigation
fix(http1): replace reachable todo!/panic! with graceful handling - #57
Merged
Merged
Conversation
alshdavid
force-pushed
the
agent/auto-flash/7a00084b4432
branch
from
October 19, 2026 09:13
8131c4e to
d46c32f
Compare
alshdavid
force-pushed
the
agent/auto-flash/7a00084b4432
branch
from
October 19, 2026 09:14
d46c32f to
5c72b88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the two reachable panics called out in #25 with graceful handling.
handle_errornow falls back to a bare 500 response if the builder rejects the response, instead oftodo!().body_streamno longer panics with.map_err(|_| panic!()). Read errors — including the writer being dropped mid-stream — now end the body stream cleanly so the client connection closes rather than the task unwinding.Fixes #25
Notes
cargo check,cargo clippy --all-targets --workspace -- -D warnings,cargo test(32 passed) andcargo xfmt --checkpass locally.