Repository navigation
Update Rust toolchain and dependencies - #63
Merged
Merged
Conversation
- jsonc-parser 0.26 -> 0.34 - crc32fast 1.5.2 -> 1.5.3 (transitive) jsonc-parser 0.34 deserializes directly into a target type, so use parse_to_serde_value::<RawTsConfig> instead of parsing to a serde_json::Value and re-converting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolchain
Rust toolchain is pinned to
1.99.1inrust-toolchain, which is already the latest stable — no change.rust-version(MSRV) is not set inCargo.toml, so it did not change either. No CI workflow pins a toolchain version (they all installstablevia rustup).Dependencies
From
Cargo.tomlchanges andcargo updateoutput:All other dependencies were already at their latest compatible/breaking version (
cargo outdated --root-deps-onlyreported onlyjsonc-parser).Code changes
One call site updated in
src/platform/transpile/typescript/tsconfig.rs: jsonc-parser 0.34'sparse_to_serde_valuenow deserializes directly into a target type, so the intermediateserde_json::Value+serde_json::from_valueconversion was removed in favour of parsing straight intoRawTsConfig.Local verification
cargo check --workspace— passcargo clippy --all-targets --workspace -- -D warnings— passcargo test --workspace— 34 passedcargo xfmt— no reformatting requiredNo dependencies were left un-upgraded.