From 163b089bd4403699c5e1fc3114861452858f42f3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Neves?= <andrerfneves@users.noreply.github.com>
Date: Thu, 25 Jun 2026 12:11:50 +0000
Subject: [PATCH] docs(deployment): fix GitLab CI example - pin docker version,
 add registry login
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The GitLab CI example used unversioned `docker:latest` and `docker:dind`
images (security anti-pattern) and was missing a Docker registry login step,
which means the `docker push` command would fail with authentication errors.

Changes:
- Pin `docker:latest` → `docker:27.2.0` (specific, reproducible version)
- Pin `docker:dind` → `docker:27.2.0-dind`
- Add `docker login` before push (required for authentication)
- Use `$CI_COMMIT_SHORT_SHA` for image tagging (traceable, unique)
---
 DEPLOYMENT_DOCKER.md | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/DEPLOYMENT_DOCKER.md b/DEPLOYMENT_DOCKER.md
index 45802f9..34a7bc0 100644
--- a/DEPLOYMENT_DOCKER.md
+++ b/DEPLOYMENT_DOCKER.md
@@ -252,13 +252,14 @@ jobs:
 
 ```yaml
 docker-build:
-  image: docker:latest
+  image: docker:27.2.0
   services:
-    - docker:dind
+    - docker:27.2.0-dind
+  before_script:
+    - docker login -u $DOCKER_USERNAME -p $DOCKER_PASSWORD
   script:
-    - docker build -t lightning-decoder .
-    - docker tag lightning-decoder registry.gitlab.com/yourusername/lightning-decoder:latest
-    - docker push registry.gitlab.com/yourusername/lightning-decoder:latest
+    - docker build -t yourusername/lightning-decoder:$CI_COMMIT_SHORT_SHA .
+    - docker push yourusername/lightning-decoder:$CI_COMMIT_SHORT_SHA
 ```
 
 ## Troubleshooting