Repository navigation
Conversation
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @chamikaramj |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
|
|
Reminder, please take a look at this pr: @Abacn |
|
BQIO storage write is a popular connector. Need to understand the implication of this optimization, if this new assumption introduced could break schema updates feature |
|
Reminder, please take a look at this pr: @Abacn |
684d88e to
8ec3fc1
Compare
@Abacn The ordinal is only a hint. We still compare fields by name after retrieving it by ordinal to make sure it's the same field (a descriptor can't have two fields with the same name). On mismatch we fall back to Is there a particular feature/case I haven't considered? Happy to amend the PR if necessary. |
fixes #40188
messageFromMapresolves every field withDescriptor.findFieldByName, which concatenates and hashes the fully qualified name on each call. This records each field's ordinal inSchemaInformationand uses it as a lookup hint, verified by name, withfindFieldByNameas the fallback.Tests: reordered descriptor (exact bytes), ordinal beyond descriptor length (fallback), required-field validation, concurrent conversion. GCP IO suite green on JDK 11 and 17.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.