ldap: use ldaps:// scheme when adding LDAP config if SSL is enabled

addConfigurationInternal always built the connectivity-test provider
URL with the plain ldap:// scheme, even when domain/global SSL
(truststore) settings are configured, unlike LdapConfiguration.getProviderUrl()
used elsewhere which already selects ldaps:// based on SSL status.

Author: weizhouapache

plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

@@ -180,7 +180,8 @@ private LdapConfigurationResponse addConfigurationInternal(final String hostname
         if (configuration == null) {
             LdapContext context = null;
             try {
-                final String providerUrl = "ldap://" + hostname + ":" + port;
+                final String protocol = LdapConfiguration.getSSLStatus(domainId) ? "ldaps://" : "ldap://";
+                final String providerUrl = protocol + hostname + ":" + port;
                 context = _ldapContextFactory.createBindContext(providerUrl,domainId);
                 configuration = new LdapConfigurationVO(hostname, port, domainId);
                 _ldapConfigurationDao.persist(configuration);