Skip to content

Commit 2736abb

Browse files
committed
Fix build after merging 4.22
1 parent 60f8894 commit 2736abb

5 files changed

Lines changed: 6 additions & 5 deletions

File tree

‎framework/extensions/src/main/java/org/apache/cloudstack/framework/extensions/network/NetworkExtensionElement.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2014,7 +2014,7 @@ public boolean completeAggregatedExecution(Network network, DeployDestination de
20142014
}
20152015

20162016
// Query all active User-VM NICs on this network
2017-
List<NicVO> nics = nicDao.listByNetworkIdAndType(network.getId(), VirtualMachine.Type.User);
2017+
List<NicVO> nics = nicDao.listNonPlaceholderNicsByNetworkIdAndType(network.getId(), VirtualMachine.Type.User);
20182018
if (CollectionUtils.isEmpty(nics)) {
20192019
logger.debug("completeAggregatedExecution: no user VM NICs on network={}, skipping", network);
20202020
return true;

‎plugins/backup/nas/src/test/java/org/apache/cloudstack/backup/NASBackupProviderTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ public void takeBackupFailureNeedingCleanupReturnsErrorBackup() throws AgentUnav
291291

292292
Mockito.when(backupDao.persist(Mockito.any(BackupVO.class))).thenAnswer(invocation -> invocation.getArgument(0));
293293

294-
Pair<Boolean, Backup> result = nasBackupProvider.takeBackup(vm, true);
294+
Pair<Boolean, Backup> result = nasBackupProvider.takeBackup(vm, true, false);
295295

296296
Assert.assertFalse(result.first());
297297
Assert.assertNotNull(result.second());
@@ -321,7 +321,7 @@ public void takeBackupFailureWithoutCleanupRemovesBackup() throws AgentUnavailab
321321

322322
Mockito.when(backupDao.persist(Mockito.any(BackupVO.class))).thenAnswer(invocation -> invocation.getArgument(0));
323323

324-
Pair<Boolean, Backup> result = nasBackupProvider.takeBackup(vm, false);
324+
Pair<Boolean, Backup> result = nasBackupProvider.takeBackup(vm, false, false);
325325

326326
Assert.assertFalse(result.first());
327327
Assert.assertNull(result.second());

‎plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@
5757

5858
import com.ceph.rados.IoCTX;
5959
import com.ceph.rados.Rados;
60+
import com.ceph.rados.exceptions.ErrorCode;
6061
import com.ceph.rados.exceptions.RadosException;
6162
import com.ceph.rbd.Rbd;
6263
import com.ceph.rbd.RbdException;

‎server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,6 @@
214214
import com.cloud.utils.exception.ExceptionProxyObject;
215215
import com.cloud.utils.fsm.NoTransitionException;
216216
import com.cloud.vm.dao.InstanceGroupDao;
217-
import com.cloud.vm.dao.InstanceGroupVMMapDao;
218217
import com.cloud.vm.dao.NicDao;
219218
import com.cloud.vm.dao.UserVmDao;
220219
import com.cloud.vm.dao.VMInstanceDetailsDao;

‎server/src/test/java/org/apache/cloudstack/backup/BackupManagerTest.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import static org.junit.Assert.assertTrue;
2323
import static org.junit.Assert.fail;
2424
import static org.mockito.ArgumentMatchers.any;
25+
import static org.mockito.ArgumentMatchers.anyBoolean;
2526
import static org.mockito.ArgumentMatchers.anyInt;
2627
import static org.mockito.ArgumentMatchers.anyString;
2728
import static org.mockito.Mockito.atLeastOnce;
@@ -794,7 +795,7 @@ public void createBackupTestFailedScheduledBackupKeepsSchedule() throws Resource
794795
Backup backup = mock(Backup.class);
795796
when(backup.getId()).thenReturn(backupId);
796797
when(backupProvider.getName()).thenReturn("testbackupprovider");
797-
when(backupProvider.takeBackup(vmInstanceVOMock, null)).thenReturn(new Pair<>(false, backup));
798+
when(backupProvider.takeBackup(vmInstanceVOMock, null, anyBoolean())).thenReturn(new Pair<>(false, backup));
798799
Map<String, BackupProvider> backupProvidersMap = new HashMap<>();
799800
backupProvidersMap.put(backupProvider.getName().toLowerCase(), backupProvider);
800801
ReflectionTestUtils.setField(backupManager, "backupProvidersMap", backupProvidersMap);

0 commit comments

Comments
 (0)