emit error event on ErrorInMaintenance, not just ErrorInPrepareForMaintenance

Author: Daan Hoogland

server/src/main/java/com/cloud/resource/ResourceManagerImpl.java

@@ -1723,6 +1723,9 @@ protected boolean setHostIntoErrorInMaintenance(HostVO host, List<VMInstanceVO>
         _haMgr.cancelScheduledMigrations(host);
         configureVncAccessForKVMHostFailedMigrations(host, errorVms);
         resourceStateTransitTo(host, ResourceState.Event.UnableToMaintain, _nodeId);
+        ActionEventUtils.onCompletedActionEvent(CallContext.current().getCallingUserId(), CallContext.current().getCallingAccountId(),
+                EventVO.LEVEL_ERROR, EventTypes.EVENT_MAINTENANCE_PREPARE_ERROR,
+                String.format("failed to put host %s into maintenance due to running VMs that could not be migrated or VMs in error state", host), host.getId(), null, 0);
         return false;
     }
 

server/src/test/java/com/cloud/resource/ResourceManagerImplTest.java

@@ -524,13 +524,17 @@ private void setupErrorVms() {
     }
 
     private void verifyErrorInMaintenanceCalls() throws NoTransitionException {
+        when(host.getResourceState()).thenReturn(ResourceState.PrepareForMaintenance);
         boolean enterMaintenanceMode = resourceManager.checkAndMaintain(hostId);
         verify(resourceManager).attemptMaintain(host);
         verify(resourceManager).setHostIntoErrorInMaintenance(eq(host), any());
         verify(resourceManager, never()).setHostIntoMaintenance(any());
         verify(resourceManager, never()).setHostIntoErrorInPrepareForMaintenance(any(), any());
         verify(resourceManager, never()).setHostIntoPrepareForMaintenanceAfterErrorsFixed(any());
         verify(resourceManager).resourceStateTransitTo(eq(host), eq(UnableToMaintain), anyLong());
+        actionEventUtilsMocked.verify(() -> ActionEventUtils.onCompletedActionEvent(
+                anyLong(), anyLong(), eq(EventVO.LEVEL_ERROR), eq(EventTypes.EVENT_MAINTENANCE_PREPARE_ERROR),
+                anyString(), eq(hostId), isNull(), eq(0L)));
         Assert.assertFalse(enterMaintenanceMode);
     }