update ResourceManagerImplTest and ManagementServerImplTest for ConfigKeys

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: Daan Hoogland

server/src/test/java/com/cloud/resource/ResourceManagerImplTest.java

@@ -36,6 +36,7 @@
 import com.cloud.host.Status;
 import com.cloud.host.dao.HostDao;
 import com.cloud.hypervisor.Hypervisor;
+import com.cloud.server.ManagementServer;
 import com.cloud.storage.ScopeType;
 import com.cloud.storage.StorageManager;
 import com.cloud.storage.StoragePoolHostVO;
@@ -198,7 +199,7 @@ public void setup() throws Exception {
         when(hostDao.findById(hostId)).thenReturn(host);
         when(host.getDetail("username")).thenReturn(hostUsername);
         when(host.getDetail("password")).thenReturn(hostPassword);
-        when(configurationDao.getValue("ssh.privatekey")).thenReturn(hostPrivateKey);
+        overrideDefaultConfigValue(ManagementServer.SshPrivateKey, "_value", hostPrivateKey);
         when(host.getStatus()).thenReturn(Status.Up);
         when(host.getPrivateIpAddress()).thenReturn(hostPrivateIp);
         when(vm1.getId()).thenReturn(vm1Id);
@@ -242,6 +243,7 @@ public void setup() throws Exception {
 
     @After
     public void tearDown() throws Exception {
+        overrideDefaultConfigValue(ManagementServer.SshPrivateKey, "_value", null);
         sshHelperMocked.close();
         actionEventUtilsMocked.close();
         getVncPortCommandMockedConstruction.close();
@@ -380,9 +382,9 @@ public void testConfigureVncAccessForKVMHostFailedMigrations() {
     }
 
     @Test(expected = CloudRuntimeException.class)
-    public void testGetHostCredentialsMissingParameter() {
+    public void testGetHostCredentialsMissingParameter() throws Exception {
         when(host.getDetail("password")).thenReturn(null);
-        when(configurationDao.getValue("ssh.privatekey")).thenReturn(null);
+        overrideDefaultConfigValue(ManagementServer.SshPrivateKey, "_value", null);
         resourceManager.getHostCredentials(host);
     }
 

server/src/test/java/com/cloud/server/ManagementServerImplTest.java

@@ -42,8 +42,11 @@
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
 
 import org.apache.cloudstack.annotation.dao.AnnotationDao;
 import org.apache.cloudstack.affinity.dao.AffinityGroupVMMapDao;
@@ -2493,4 +2496,32 @@ public void createDeploymentPlanForMigrationListingTestAllocatesInSourceClusterW
         Assert.assertEquals(5L, (long) deploymentPlan.getPodId());
         Assert.assertEquals(4L, (long) deploymentPlan.getClusterId());
     }
+
+    @Test
+    public void configureSchedulesAlertPurgeTaskWhenAlertPurgeDelayIsNonZero() throws Exception {
+        when(configDao.getConfiguration()).thenReturn(new HashMap<>());
+        overrideDefaultConfigValue(spy.AlertPurgeInterval, "_defaultValue", "10");
+        overrideDefaultConfigValue(spy.AlertPurgeDelay, "_defaultValue", "5");
+        ScheduledExecutorService alertExecutor = mock(ScheduledExecutorService.class);
+        ReflectionTestUtils.setField(spy, "_alertExecutor", alertExecutor);
+
+        spy.configure("management-server", new HashMap<>());
+
+        Mockito.verify(alertExecutor).scheduleAtFixedRate(any(Runnable.class), Mockito.eq(10L), Mockito.eq(10L), Mockito.eq(TimeUnit.SECONDS));
+        Assert.assertEquals(5, ReflectionTestUtils.getField(spy, "_alertPurgeDelay"));
+    }
+
+    @Test
+    public void configureDoesNotScheduleAlertPurgeTaskWhenAlertPurgeDelayIsZero() throws Exception {
+        when(configDao.getConfiguration()).thenReturn(new HashMap<>());
+        overrideDefaultConfigValue(spy.AlertPurgeInterval, "_defaultValue", "10");
+        overrideDefaultConfigValue(spy.AlertPurgeDelay, "_defaultValue", "0");
+        ScheduledExecutorService alertExecutor = mock(ScheduledExecutorService.class);
+        ReflectionTestUtils.setField(spy, "_alertExecutor", alertExecutor);
+
+        spy.configure("management-server", new HashMap<>());
+
+        Mockito.verifyNoInteractions(alertExecutor);
+        Assert.assertEquals(0, ReflectionTestUtils.getField(spy, "_alertPurgeDelay"));
+    }
 }