From ee78e6f466dc895252bff146f1c2bddf771db3e1 Mon Sep 17 00:00:00 2001 From: Paul Vogel Date: Tue, 10 Nov 2026 17:37:26 +0100 Subject: [PATCH 1/4] fix class name casing of waterfall proxy log in detective --- src/Detective/Detective.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Detective/Detective.php b/src/Detective/Detective.php index 3c778ceb..87d9d2a4 100644 --- a/src/Detective/Detective.php +++ b/src/Detective/Detective.php @@ -77,7 +77,7 @@ class Detective extends \Aternos\Codex\Detective\Detective BedrockContentLog::class, FabricServerLog::class, BungeeCordProxyLog::class, - WaterfallProxyLog::class, + WaterFallProxyLog::class, VelocityProxyLog::class, GeyserProxyLog::class, GlowstoneServerLog::class, From 13bef358cbdf3df3a10e865084c908adfab7af82 Mon Sep 17 00:00:00 2001 From: Paul Vogel Date: Tue, 10 Nov 2026 17:38:25 +0100 Subject: [PATCH 2/4] use instanceof in minecraft problem equality check --- src/Analysis/Problem/MinecraftProblem.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Analysis/Problem/MinecraftProblem.php b/src/Analysis/Problem/MinecraftProblem.php index 81b9dd15..d52b25f4 100644 --- a/src/Analysis/Problem/MinecraftProblem.php +++ b/src/Analysis/Problem/MinecraftProblem.php @@ -22,6 +22,6 @@ abstract class MinecraftProblem extends Problem implements PatternInsightInterfa */ public function isEqual(InsightInterface $insight): bool { - return get_class($this) === get_class($insight); + return $insight instanceof static; } } \ No newline at end of file From 81a32abb6dfb58ebe6d6b743335dfedc8f90ff4f Mon Sep 17 00:00:00 2001 From: Paul Vogel Date: Tue, 10 Nov 2026 17:39:07 +0100 Subject: [PATCH 3/4] make dependency plugin name return type non-nullable --- src/Analysis/Problem/Bukkit/PluginDependencyProblem.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Analysis/Problem/Bukkit/PluginDependencyProblem.php b/src/Analysis/Problem/Bukkit/PluginDependencyProblem.php index 5e99f2af..aac0217c 100644 --- a/src/Analysis/Problem/Bukkit/PluginDependencyProblem.php +++ b/src/Analysis/Problem/Bukkit/PluginDependencyProblem.php @@ -11,9 +11,9 @@ class PluginDependencyProblem extends PluginFileProblem protected string $dependencyPluginName; /** - * @return string|null + * @return string */ - public function getDependencyPluginName(): ?string + public function getDependencyPluginName(): string { return $this->dependencyPluginName; } From 1b17272cf0c3d619b0a30745fe178deb87124566 Mon Sep 17 00:00:00 2001 From: Paul Vogel Date: Tue, 10 Nov 2026 17:40:08 +0100 Subject: [PATCH 4/4] only add update java solution if java version is known --- .../Problem/Bukkit/UnsupportedClassVersionProblem.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Analysis/Problem/Bukkit/UnsupportedClassVersionProblem.php b/src/Analysis/Problem/Bukkit/UnsupportedClassVersionProblem.php index 23e8223d..bab42df9 100644 --- a/src/Analysis/Problem/Bukkit/UnsupportedClassVersionProblem.php +++ b/src/Analysis/Problem/Bukkit/UnsupportedClassVersionProblem.php @@ -44,7 +44,10 @@ public function setMatches(array $matches, mixed $patternKey): void $this->classFileVersion = intval($matches[3]); } - $this->addSolution(new UpdateJavaSolution($this->getJavaVersion())); + $javaVersion = $this->getJavaVersion(); + if ($javaVersion !== null) { + $this->addSolution(new UpdateJavaSolution($javaVersion)); + } }